From owner-freebsd-net@FreeBSD.ORG  Wed Sep  5 04:57:04 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 42605106566C;
	Wed,  5 Sep 2012 04:57:04 +0000 (UTC)
	(envelope-from pyunyh@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 028D58FC0A;
	Wed,  5 Sep 2012 04:57:03 +0000 (UTC)
Received: by pbbrp2 with SMTP id rp2so302175pbb.13
	for <multiple recipients>; Tue, 04 Sep 2012 21:57:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:date:to:cc:subject:message-id:reply-to:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	bh=G/CU4kU2hyr88vR189DS3OG51VpdmzJar6HjPVVa2Oc=;
	b=clQ9d7/AQnMw7Nj1zc5GwtfwpEAWbg5sEagf4bvduf52vjDAg2bzUbT5FPrIqXwSXP
	gY0hDGoP3KylOkATadyTkwYioLgm8KmqNlZLxA6nlYtGI3sT9mJ7mNdPyNE4KE9b2y4W
	qCpW/60/UgHAlVbNTjLK1Ol+un7dMESzlERqcjF6LuommmIyXtXuAcGooTbr3rDGZJbm
	tTYqrb8cFOKEOWdrhKfI9jFz1eNUo4MIBEWKwfBdOTichI0ELyhpazTo/ToYzzzpqsL6
	aGCDLcYc8QMcBMaCoBM4ESVVO5ez3LVIPfmKU1eWZWU56NoxiiPDlPy/+2JIWAGon2el
	rc9Q==
Received: by 10.68.217.69 with SMTP id ow5mr50935038pbc.35.1346821023631;
	Tue, 04 Sep 2012 21:57:03 -0700 (PDT)
Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249])
	by mx.google.com with ESMTPS id jz10sm596265pbc.8.2012.09.04.21.57.00
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 04 Sep 2012 21:57:02 -0700 (PDT)
Received: by pyunyh@gmail.com (sSMTP sendmail emulation);
	Wed, 05 Sep 2012 13:56:54 -0700
From: YongHyeon PYUN <pyunyh@gmail.com>
Date: Wed, 5 Sep 2012 13:56:54 -0700
To: Mike Silbersack <silby@silby.com>
Message-ID: <20120905205654.GA1449@michelle.cdnetworks.com>
References: <5046D681.2040806@silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5046D681.2040806@silby.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net@freebsd.org, davidch@freebsd.org, yongari@freebsd.org
Subject: Re: [patch] if_bxe shutdown fix
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: pyunyh@gmail.com
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2012 04:57:04 -0000

On Tue, Sep 04, 2012 at 11:35:13PM -0500, Mike Silbersack wrote:
> Does anyone want to review this patch before I check it in?  The change 
> has been reviewed and tested by coworkers, but not yet reviewed by any 
> other FreeBSD committers.
> 
> http://www.silby.com/patches/if_bxe.c-safestop.patch
> 
> This resolves an issue we saw at work where IPMI would report bus errors 
> when you rebooted a system with bxe NICs if you had not UP'd all of the 
> bxe NICs before the shutdown.

Yeah I also have a similar patch. But I checked sc->state after
getting a BXE_CORE_LOCK as the state is protected by the lock.

> 
> Thanks,
> 
> Mike "Silby" Silbersack