From owner-freebsd-fs@FreeBSD.ORG Wed Aug 6 09:30:05 2008 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D9811065677 for ; Wed, 6 Aug 2008 09:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6AD398FC1F for ; Wed, 6 Aug 2008 09:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m769U5m3008915 for ; Wed, 6 Aug 2008 09:30:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m769U5Yf008912; Wed, 6 Aug 2008 09:30:05 GMT (envelope-from gnats) Date: Wed, 6 Aug 2008 09:30:05 GMT Message-Id: <200808060930.m769U5Yf008912@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: "Mateusz Guzik" Cc: Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mateusz Guzik List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 09:30:05 -0000 The following reply was made to PR kern/126287; it has been noted by GNATS. From: "Mateusz Guzik" To: bug-followup@freebsd.org Cc: Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled Date: Wed, 6 Aug 2008 11:24:16 +0200 ------=_Part_20104_30199813.1218014656704 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, function vfs_deleteopt() was called with NULL pointer (opts) used in TAILQ_FOREACH_SAFE macro -- I believe that simple `if (opts == NULL) return; ' in that function is ok to fix this. (Take a look at attachment.) At least the kernel does not panic. ;) Thanks, -- Mateusz Guzik ------=_Part_20104_30199813.1218014656704 Content-Type: application/octet-stream; name=vfs_mount.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fjjqf5in0 Content-Disposition: attachment; filename=vfs_mount.diff LS0tIHN5cy9rZXJuL3Zmc19tb3VudC5jLm9yaWcJMjAwOC0wOC0wNiAxMToxNDoxNi4wMDAwMDAw MDAgKzAyMDAKKysrIHN5cy9rZXJuL3Zmc19tb3VudC5jCTIwMDgtMDgtMDYgMTE6MTQ6MzIuMDAw MDAwMDAwICswMjAwCkBAIC0xOTYsMTAgKzE5NiwxMyBAQAogdm9pZAogdmZzX2RlbGV0ZW9wdChz dHJ1Y3QgdmZzb3B0bGlzdCAqb3B0cywgY29uc3QgY2hhciAqbmFtZSkKIHsKIAlzdHJ1Y3QgdmZz b3B0ICpvcHQsICp0ZW1wOwogCisJaWYgKG9wdHMgPT0gTlVMTCkKKwkJcmV0dXJuOworCiAJVEFJ TFFfRk9SRUFDSF9TQUZFKG9wdCwgb3B0cywgbGluaywgdGVtcCkgIHsKIAkJaWYgKHN0cmNtcChv cHQtPm5hbWUsIG5hbWUpID09IDApCiAJCQl2ZnNfZnJlZW9wdChvcHRzLCBvcHQpOwogCX0KIH0K ------=_Part_20104_30199813.1218014656704--