From owner-svn-src-all@FreeBSD.ORG Sat Jul 19 22:19:44 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D7D94F3; Sat, 19 Jul 2014 22:19:44 +0000 (UTC) Received: from mail-qc0-x22d.google.com (mail-qc0-x22d.google.com [IPv6:2607:f8b0:400d:c01::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BED59240E; Sat, 19 Jul 2014 22:19:43 +0000 (UTC) Received: by mail-qc0-f173.google.com with SMTP id c9so4440814qcz.4 for ; Sat, 19 Jul 2014 15:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=GbbGu9kL+Zrp2s5plO/PEgkUJqnabTN0GoxhaJXxtQc=; b=aZVU1tgVGFXNL4PNq6b5RXQ5lFdJb3KqMRYFREWC4p3XCy83DclY/Xcq0WSTmUxgM5 fPc29169ZX7+bNENXbciqy9CrFVvO76RlsLbGO4lNbgBGuD8uugu627ZArTwOOrOY7zA ModQ/3gp8IU9YpRp+9MdJr4W695Q92XRwwAwJAr4nsuv4E1eUB2rOJpmGPPzg7FKYqCT ymNkOZypYbiewEKwihiw3qAtQXwTBUFNh0q26ijZTnvapIYI9tbXCSA4NG3vvXf3Fagc P5wjk4jLJ/o89mku9mZKlSblcNNdx+CvgSLSUhTvATOApWN4ZlBWBnhPVxspTLG/2NTf JWNQ== MIME-Version: 1.0 X-Received: by 10.224.71.198 with SMTP id i6mr24710406qaj.76.1405808382764; Sat, 19 Jul 2014 15:19:42 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.1.6 with HTTP; Sat, 19 Jul 2014 15:19:42 -0700 (PDT) In-Reply-To: <1405805007.85788.24.camel@revolution.hippie.lan> References: <201407191426.s6JEQ4en083862@svn.freebsd.org> <1405805007.85788.24.camel@revolution.hippie.lan> Date: Sat, 19 Jul 2014 15:19:42 -0700 X-Google-Sender-Auth: CrQhTJLnZ2BqAGeVsGsfncRLnrY Message-ID: Subject: Re: svn commit: r268877 - head/share/mk From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 22:19:44 -0000 On 19 July 2014 14:23, Ian Lepore wrote: > On Sat, 2014-07-19 at 14:26 +0000, Dag-Erling Sm=C3=B8rgrav wrote: >> Author: des >> Date: Sat Jul 19 14:26:04 2014 >> New Revision: 268877 >> URL: http://svnweb.freebsd.org/changeset/base/268877 >> >> Log: >> Use -o (output to file) instead of -t (print to stdout) and a redirect= . >> >> MFC after: 1 week >> >> Modified: >> head/share/mk/bsd.dep.mk >> >> Modified: head/share/mk/bsd.dep.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/share/mk/bsd.dep.mk Sat Jul 19 14:10:31 2014 (r268876) >> +++ head/share/mk/bsd.dep.mk Sat Jul 19 14:26:04 2014 (r268877) >> @@ -82,7 +82,7 @@ ${_S:R}.o: ${_S} >> .for _LSRC in ${SRCS:M*.l:N*/*} >> .for _LC in ${_LSRC:R}.c >> ${_LC}: ${_LSRC} >> - ${LEX} -t ${LFLAGS} ${.ALLSRC} > ${.TARGET} >> + ${LEX} ${LFLAGS} -o ${.TARGET} ${.ALLSRC} >> .if !exists(${.OBJDIR}/${DEPENDFILE}) >> ${_LC:R}.o: ${_LC} >> .endif >> > > This change breaks the ability to bootstrap from versions prior to 10.0 > because the older lex requires "-ofilename" rather than "-o filename". > Even more annoying, it's not possible to fix it by building the new lex > earlier in bootstrap because the new lex requires a newer m4 be built > first, and building the new m4 requires running this rule which doesn't > work with the old lex. Grrrr. > > It seems like the path of least resistance would be to remove the space > between -o and ${TARGET}, which I'll leave for you if you agree, so that > you can MFC them together when the time comes. Hm, why not build lex as a bootstrap tool then, or is this too early in the process? -a