From owner-freebsd-hackers Mon Jan 19 21:46:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA05096 for hackers-outgoing; Mon, 19 Jan 1998 21:46:17 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from wcc.wcc.net (wcc.wcc.net [208.6.232.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA05082 for ; Mon, 19 Jan 1998 21:46:10 -0800 (PST) (envelope-from piquan@wcc.wcc.net) Received: from detlev.UUCP (ppp133.wcc.net [208.6.232.133]) by wcc.wcc.net (8.8.7/8.8.7) with ESMTP id XAA29200; Mon, 19 Jan 1998 23:42:52 -0600 (CST) Received: (from joelh@localhost) by detlev.UUCP (8.8.8/8.8.7) id XAA00312; Mon, 19 Jan 1998 23:45:25 -0600 (CST) (envelope-from joelh) Date: Mon, 19 Jan 1998 23:45:25 -0600 (CST) Message-Id: <199801200545.XAA00312@detlev.UUCP> To: freebsd-hackers@FreeBSD.ORG Subject: syscons.c Mode X handling From: Joel Ray Holveck Reply-to: joelh@gnu.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk I'll be the first to admit that I don't know a thing about VGA programming, but, unless I'm wrong, there is definately something awry in this bit of code, from syscons.c:set_mode, in case M_VGA_MODEX, line 4055. This could be perfectly harmless, but special_modetable[10+0x11] gets set twice before anything is done with it. (special_modetable is a normal char array on the stack.) Anybody know what's going on here? This isn't anything that's important to my work, I just came across it while going over the mode-switching code, and it looks funny. /* set 240 lines */ special_modetable[10+0x11] = 0x2c; special_modetable[10+0x06] = 0x0d; special_modetable[10+0x07] = 0x3e; special_modetable[10+0x10] = 0xea; special_modetable[10+0x11] = 0xac; Happy hacking, joelh -- Joel Ray Holveck - joelh@gnu.org - http://www.wp.com/piquan Fourth law of programming: Anything that can go wrong wi sendmail: segmentation violation - core dumped