From owner-freebsd-xen@FreeBSD.ORG  Thu Apr 30 09:58:43 2015
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8BE2C634
 for <freebsd-xen@freebsd.org>; Thu, 30 Apr 2015 09:58:43 +0000 (UTC)
Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (Client CN "mail.citrix.com",
 Issuer "Cybertrust Public SureServer SV CA" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3A87A1CF0
 for <freebsd-xen@freebsd.org>; Thu, 30 Apr 2015 09:58:42 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="5.11,676,1422921600"; d="scan'208";a="258090858"
Message-ID: <5541FC8A.8080009@citrix.com>
Date: Thu, 30 Apr 2015 11:57:30 +0200
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: =?windows-1252?Q?Gustau_P=E9rez?= <gperez@entel.upc.edu>, FreeBSD XEN
 <freebsd-xen@freebsd.org>
Subject: Re: Porting the block-iscsi hotplug script
References: <553DEB97.5000300@entel.upc.edu> <5540A053.4080409@entel.upc.edu>
 <5540F3FC.80606@citrix.com>
In-Reply-To: <5540F3FC.80606@citrix.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-DLP: MIA2
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen/>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2015 09:58:43 -0000

Hello,

El 29/04/15 a les 17.08, Roger Pau Monné ha escrit:
> Yes, libxl needs some modifications in order to execute hotplug scripts
> for block devices on FreeBSD. If you take a look at
> tools/libxl/libxl_freebsd.c:libxl__get_hotplug_script_info you will see
> that hotplug scripts are only executed if the device is a nic.
> 
> I will try to craft a patch tomorrow to enable the execution of disk
> hotplug scripts for FreeBSD. Also, if you run xl with "-vvv" you will
> get a lot more of debugging info which might be helpful.
> 
> Since there are no block hotplug scripts for FreeBSD yet there's no
> description about how parameters will be passed. I will also send you
> the calling convention and what is expected to be filled by the hotplug
> script upon execution together with the patch.

I've been digging into this, and it looks like it's going to be more
complicated than what I thought. FreeBSD blkback is not prepared to work
with hotplug scripts so we also need to modify it.

I hope I'm going to have some time next week to prepare a patch to both
the FreeBSD kernel and libxl, sorry for the delay.

Roger.