From owner-svn-src-all@freebsd.org Thu Aug 27 09:01:33 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D14F9C3FC3 for ; Thu, 27 Aug 2015 09:01:33 +0000 (UTC) (envelope-from julien@jch.io) Received: from mail-qg0-f53.google.com (mail-qg0-f53.google.com [209.85.192.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A894BF9 for ; Thu, 27 Aug 2015 09:01:32 +0000 (UTC) (envelope-from julien@jch.io) Received: by qgeh99 with SMTP id h99so8971997qge.0 for ; Thu, 27 Aug 2015 02:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=Hiwx4ePXnV0gdmAO4g3NcVbkop0yrkrPwcgT0UJLSuI=; b=WCSOh17qzrKNKiUpR6wr0o8RoUP4yyoImYxSL67hobAVM0r3u3sivOMJWSYf6f776E mZsfWmOHd1U44XktfBvX3IgMH+/ZUxOaVXaeCgAA7691YUF2GuVpzcZw539Pm78f48De Gkzj3K4Rts3bT2U5iNDhsSPu/sNSI19q3iaEq7zhGf5Fx4F8WE/vf99x+Mfkm2DdA6Xv IunnezJOdYv8n0+RuOiGIHFg+dKTZvnpA5zMYB8ODazIMM1qK7N7Wm92EyS6pY0+cLuZ ZpVA3SGOPgo7H5AOCGyvDap6gwDLWTgKkawTagDOyU3FPiFjgLqHTWMwF54gpmYUv/NO HvPg== X-Gm-Message-State: ALoCoQmxIntRetJzYu+RHhcW1WjeQKnPWdajr71AR1nVj5NUkp7YD1rapzgLxkwPIJedDRAIqkuO X-Received: by 10.140.194.17 with SMTP id p17mr5042316qha.62.1440666085860; Thu, 27 Aug 2015 02:01:25 -0700 (PDT) Received: from FRI2JCHARBON-M1.local (h87.s239.verisign.com. [216.168.239.87]) by smtp.googlemail.com with ESMTPSA id t69sm914697qki.11.2015.08.27.02.01.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Aug 2015 02:01:25 -0700 (PDT) Subject: Re: svn commit: r286880 - head/sys/kern To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, John Baldwin , Adrian Chadd References: <201508181015.t7IAFAex055889@repo.freebsd.org> <55DD69E5.4090904@selasky.org> <55DD74EB.30601@selasky.org> <55DE01F7.8040508@freebsd.org> <55DE0615.5050303@selasky.org> From: Julien Charbon X-Enigmail-Draft-Status: N1110 Message-ID: <55DED1E3.3090004@freebsd.org> Date: Thu, 27 Aug 2015 11:01:23 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55DE0615.5050303@selasky.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4R9tPBdsfipjFOhLP6q0450aqq7PicPxq" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2015 09:01:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Hans, On 26/08/15 20:31, Hans Petter Selasky wrote: > On 08/26/15 20:14, Julien Charbon wrote: >> Let say that if nobody screams until Friday 8/28, I will put back >> r284245 and revert this change_and_ I will make this case clear in th= e >> man page. >=20 > If you can update the manual page about this special case for MPSAFE > callouts only I presume, then its totally fine. Good idea, I am going to update the callout(9) man page to make clear that in mpsafe case if a callout is pending and currently being serviced callout_stop() returns 0 (fail). > Then I can update my projects/hps_head to follow that new change, > which now is a bit broken. You might also want to check existing > MPSAFE consumers in the kernel, if this API change makes any > difference. I checked all the mpsafe callouts that check callout_stop() return value (actually only a few are testing callout_stop() return value), and none relies on the old behavior (i.e. before r286880). > I was thinking if user-space TCP might be affected by this. CC'ing Adri= an. Interesting. -- Julien --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJV3tHjAAoJEKVlQ5Je6dhxubYH/A4MsY+FJnJAzbwqiOF2Hub1 mIKHGurrsBTbIsv3E3rOyBFDdu7cK0vMulwmbNWSLzoyviCK14FMIn+LCkhYEKTl NMrXbVR1wSfP7DcrOM1JvqV+PyKRjhyAKPrhTfHlR7SwfTxypFof8d+1c9JvyWY+ SAqSqqNUIEBr4qf+ksVFWKm6qv3a0wZjnVUwtkGSjBQgTtvjKUUvM7SUv8cV6HJV 0y4a9pP/06nwXV08TQ2pZv9Ew8x8IDQ6LvAr2uKLOEIGKXXcF+wyc4HZE3sZx3cv md7jOOAwsTOon9FpwWsLkEQbb7Xhi/w4Xw412/hzJQ0449xzyCV4NF8519Pq3hQ= =khMM -----END PGP SIGNATURE----- --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq--