From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 31 11:20:07 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B1A61065697 for ; Mon, 31 Aug 2009 11:20:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5281F8FC0C for ; Mon, 31 Aug 2009 11:20:03 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VBK3o8084812 for ; Mon, 31 Aug 2009 11:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7VBK3g5084811; Mon, 31 Aug 2009 11:20:03 GMT (envelope-from gnats) Resent-Date: Mon, 31 Aug 2009 11:20:03 GMT Resent-Message-Id: <200908311120.n7VBK3g5084811@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Patroklos Argyroudis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 916E410656A6 for ; Mon, 31 Aug 2009 11:10:01 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 7FB498FC2D for ; Mon, 31 Aug 2009 11:10:01 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VBA1pn012200 for ; Mon, 31 Aug 2009 11:10:01 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7VBA1Op012199; Mon, 31 Aug 2009 11:10:01 GMT (envelope-from nobody) Message-Id: <200908311110.n7VBA1Op012199@www.freebsd.org> Date: Mon, 31 Aug 2009 11:10:01 GMT From: Patroklos Argyroudis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/138388: NULL pointer dereference in pcfclock_open() in file sys/dev/ppbus/pcfclock.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 11:20:07 -0000 >Number: 138388 >Category: kern >Synopsis: NULL pointer dereference in pcfclock_open() in file sys/dev/ppbus/pcfclock.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 31 11:20:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Patroklos Argyroudis >Release: 8.0-CURRENT >Organization: census, inc >Environment: N/A >Description: There is a NULL pointer dereference in pcfclock_open() in file sys/dev/ppbus/pcfclock.c at line 153. The NULL check at line 157 should be before the dereference of sc at line 153. >How-To-Repeat: N/A >Fix: Patch attached. Patch attached with submission follows: --- ./sys/dev/ppbus/pcfclock.c.orig 2009-08-28 16:24:15.000000000 +0300 +++ ./sys/dev/ppbus/pcfclock.c 2009-08-28 16:25:34.000000000 +0300 @@ -150,13 +150,16 @@ pcfclock_open(struct cdev *dev, int flag, int fms, struct thread *td) { struct pcfclock_data *sc = dev->si_drv1; - device_t pcfclockdev = sc->dev; - device_t ppbus = device_get_parent(pcfclockdev); + device_t pcfclockdev; + device_t ppbus; int res; if (!sc) return (ENXIO); + pcfclockdev = sc->dev; + ppbus = device_get_parent(pcfclockdev); + ppb_lock(ppbus); res = ppb_request_bus(ppbus, pcfclockdev, (flag & O_NONBLOCK) ? PPB_DONTWAIT : PPB_WAIT); >Release-Note: >Audit-Trail: >Unformatted: