From owner-svn-src-all@FreeBSD.ORG  Tue Mar  2 19:22:19 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 264D91065673;
	Tue,  2 Mar 2010 19:22:19 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-ew0-f226.google.com (mail-ew0-f226.google.com
	[209.85.219.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 421F28FC1C;
	Tue,  2 Mar 2010 19:22:17 +0000 (UTC)
Received: by ewy26 with SMTP id 26so452923ewy.3
	for <multiple recipients>; Tue, 02 Mar 2010 11:22:11 -0800 (PST)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.103.125.37 with SMTP id c37mr5262067mun.3.1267557731172; Tue, 
	02 Mar 2010 11:22:11 -0800 (PST)
In-Reply-To: <20100302190344.GA5490@onelab2.iet.unipi.it>
References: <201003021740.o22HemPA096942@svn.freebsd.org>
	<20100302185130.GC2489@deviant.kiev.zoral.com.ua> 
	<20100302190344.GA5490@onelab2.iet.unipi.it>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Tue, 2 Mar 2010 11:21:51 -0800
X-Google-Sender-Auth: 2dac017363940d87
Message-ID: <eaa228be1003021121re2eb088g175daa15b2c07b18@mail.gmail.com>
To: Luigi Rizzo <rizzo@iet.unipi.it>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Kostik Belousov <kostikbel@gmail.com>, svn-src-head@freebsd.org,
	Luigi Rizzo <luigi@freebsd.org>, src-committers@freebsd.org,
	svn-src-all@freebsd.org
Subject: Re: svn commit: r204591 - in head: sbin/ipfw sys/conf sys/net 
	sys/netinet sys/netinet/ipfw sys/netinet/ipfw/test
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Mar 2010 19:22:19 -0000

On Tue, Mar 2, 2010 at 11:03, Luigi Rizzo <rizzo@iet.unipi.it> wrote:
> On Tue, Mar 02, 2010 at 08:51:30PM +0200, Kostik Belousov wrote:
>> > --- head/sbin/ipfw/Makefile Tue Mar =A02 17:34:11 2010 =A0 =A0 =A0 =A0=
(r204590)
>> > +++ head/sbin/ipfw/Makefile Tue Mar =A02 17:40:48 2010 =A0 =A0 =A0 =A0=
(r204591)
>> > @@ -3,7 +3,6 @@
>> > =A0PROG=3D =A0 =A0 =A0ipfw
>> > =A0SRCS=3D =A0 =A0 =A0ipfw2.c dummynet.c ipv6.c main.c nat.c altq.c
>> > =A0WARNS?=3D =A0 =A02
>> > -DPADD=3D =A0 =A0 ${LIBUTIL}
>> > =A0LDADD=3D =A0 =A0 -lutil
>> > =A0MAN=3D =A0 =A0 =A0 ipfw.8
>> Removal of DPADD is most likely regression ?
>
> possibly.
> i couldn't figure out why it was there in the
> first place, can you clarify what it was for ?

It allows "make depend" to set the proper dependency on the libraries
you're linking in.