From owner-freebsd-current@FreeBSD.ORG Sat Sep 15 21:52:06 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEBEC16A418 for ; Sat, 15 Sep 2007 21:52:06 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id 7F0A713C45B for ; Sat, 15 Sep 2007 21:52:06 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l8FLq1i2075897; Sat, 15 Sep 2007 16:52:02 -0500 (CDT) (envelope-from scf@FreeBSD.org) Date: Sat, 15 Sep 2007 16:52:01 -0500 (CDT) From: "Sean C. Farley" To: "YAMAMOTO, Taku" In-Reply-To: <20070910081425.3c45bca7.taku@tackymt.homeip.net> Message-ID: References: <20070910081425.3c45bca7.taku@tackymt.homeip.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on mail.farley.org Cc: freebsd-current@FreeBSD.org Subject: Re: setenv() doesn't export unsetenv()ed variables to environ X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2007 21:52:07 -0000 On Mon, 10 Sep 2007, YAMAMOTO, Taku wrote: > Greetings, > > I found a regression in src/lib/libc/stdlib/getenv.c during tracking > strange behaviour of the sshguard-pf. > > In short, setenv() doesn't add an entry to environ[] if the name was > once removed by unsetenv(). > > I'm suspecting the function __setenv() lacks care of the case to reuse > a deactivated entry and it needs the following change: I just committed the patch. Thank you. Sean -- scf@FreeBSD.org