From owner-freebsd-bugs@FreeBSD.ORG Thu Apr 17 08:20:00 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4C053B5 for ; Thu, 17 Apr 2014 08:20:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 908C5197C for ; Thu, 17 Apr 2014 08:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3H8K0Uf065828 for ; Thu, 17 Apr 2014 08:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3H8K0Ps065827; Thu, 17 Apr 2014 08:20:00 GMT (envelope-from gnats) Resent-Date: Thu, 17 Apr 2014 08:20:00 GMT Resent-Message-Id: <201404170820.s3H8K0Ps065827@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dirk-Willem van Gulik Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8B467258 for ; Thu, 17 Apr 2014 08:12:35 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5D14A18E4 for ; Thu, 17 Apr 2014 08:12:35 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s3H8CZt3096202 for ; Thu, 17 Apr 2014 08:12:35 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s3H8CYxd096189; Thu, 17 Apr 2014 08:12:34 GMT (envelope-from nobody) Message-Id: <201404170812.s3H8CYxd096189@cgiserv.freebsd.org> Date: Thu, 17 Apr 2014 08:12:34 GMT From: Dirk-Willem van Gulik To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/188715: int64 not handled right as arg on badsect(8), possible other issues lurking X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2014 08:20:00 -0000 >Number: 188715 >Category: bin >Synopsis: int64 not handled right as arg on badsect(8), possible other issues lurking >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 17 08:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Dirk-Willem van Gulik >Release: 9.2-RELEASE-p3 >Organization: Web Weaving >Environment: pikmeer.webweaving.org 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0: Sat Jan 11 02:38:15 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Was trying to map out some bad blocks prior to temporarily read/empty 4 Tbyte volume using ‚badsect(8)’ - and returing it. Was expecting to be able to put the sector # into badsect (e.g. 3432631424 from below FSCK output). This gave me a bit of an odd: badsect: 3432631424: Result too large As the daddr_t seems to be a 64bit unsigned; I assumed that the: number = strtol(*argv, NULL, 0); was some legacy culprint - and changed it to a strtoll as the daddr_t you are entering is an int 64. number = strtoll(*argv, NULL, 0); That gets it past that point; only to segv out on: cg = dtog(fs, fsbn); /usr/include/ufs/ffs/fs.h:#define dtog(fs, d) ((d) / (fs)->fs_fpg) /usr/include/ufs/ffs/fs.h:#define dtogd(fs, d) ((d) % (fs)->fs_fpg) a bit later. While fs is valid - it seems fs->fs_fpg returns as ‚0’ — why is this ? Is geom too new ? Or is badsect too old/retired ? Dw. aacd1: hard error cmd=read 4246326690-4246326721 . fsck(8):... THE FOLLOWING DISK SECTORS COULD NOT BE READ: 3432631424, 3432631425, 3432631426, 3432631427, 3432631428, 3432631429, 3432631430, 3432631431, 3432631432, 3432631433, 3432631434, 3432631435, 3432631436, 3432631437, 3432631438, 3432631439, 3432631440, 3432631441, 3432631442, 3432631443, 3432631444, 3432631445, 3432631446, 3432631447, 3432631448, 3432631449, 3432631450, 3432631451, 3432631452, 3432631453, 3432631454, 3432631455, $sudo geom label list aacd0s1d Geom name: aacd0s1d Providers: 1. Name: ufsid/4a08af657f7e3930 Mediasize: 4544528384 (4.2G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 536903168 Mode: r0w0e0 secoffset: 0 offset: 0 seclength: 8876032 length: 4544528384 index: 0 Consumers: 1. Name: aacd0s1d Mediasize: 4544528384 (4.2G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 536903168 Mode: r0w0e0 >How-To-Repeat: Run badsect with a >32 bit number. Observe it giving a Result too large >Fix: See above strtoll change -- but that uncovers another odd issue. >Release-Note: >Audit-Trail: >Unformatted: