From owner-svn-src-head@freebsd.org  Fri Jun 23 06:54:42 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9565FD9E015;
 Fri, 23 Jun 2017 06:54:42 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 73E757A827;
 Fri, 23 Jun 2017 06:54:40 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA26236;
 Fri, 23 Jun 2017 09:54:33 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1dOIUD-00010C-Hq; Fri, 23 Jun 2017 09:54:33 +0300
Subject: Re: svn commit: r320156 - in head: cddl/contrib/opensolaris/cmd/zdb
 cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzfs/common
 sys/cddl/contrib/opensolaris/common/zfs sys/cddl/contri...
To: Justin Hibbits <jrh29@alumni.cwru.edu>
Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>,
 "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>,
 "svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org>
References: <201706201739.v5KHdPhO051256@repo.freebsd.org>
 <CAHSQbTD+8w3bM9cfYa_vapk2Mqo1rRqzOLNsiAJKbekHcOgyLQ@mail.gmail.com>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <8c556315-b267-54c1-049a-c401ab0d6b09@FreeBSD.org>
Date: Fri, 23 Jun 2017 09:53:37 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAHSQbTD+8w3bM9cfYa_vapk2Mqo1rRqzOLNsiAJKbekHcOgyLQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jun 2017 06:54:42 -0000

On 23/06/2017 06:10, Justin Hibbits wrote:
> This commit breaks gcc builds with new warnings introduced:
> 
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c: In function 'arc_kmem_reap_now':
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c:4364: warning: nested extern declaration of 'abd_chunk_cache' [-Wnested-externs]
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c: In function 'vdev_label_write_pad2': 
> /home/chmeee/freebsd/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c:902:
> warning: passing argument 2 of 'abd_copy_from_buf' discards qualifiers from
> pointer target type 

I missed the first one during the merge.
The second one is in FreeBSD specific code, but the root cause is that the
interface introduced upstream takes a non-const parameter where it should really
take a const one.

Thank you for the report.  I'll handle this.

-- 
Andriy Gapon