Date: Tue, 7 Dec 2004 06:25:02 +0100 From: Michael Nottebrock <michaelnottebrock@gmx.net> To: Dejan Lesjak <dejan.lesjak@ijs.si> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: [ports-i386@dosirak.kr.freebsd.org: kaptain-0.72 failed on i386 5] Message-ID: <200412070625.03222.michaelnottebrock@gmx.net> In-Reply-To: <200412061803.39398.dejan.lesjak@ijs.si> References: <20041205072925.GG72828@xor.obsecurity.org> <200412051226.18976.michaelnottebrock@gmx.net> <200412061803.39398.dejan.lesjak@ijs.si>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Monday, 6. December 2004 18:03, Dejan Lesjak wrote:
> On Sunday 05 of December 2004 12:26, Michael Nottebrock wrote:
> > On Sunday, 5. December 2004 08:29, Kris Kennaway wrote:
> > > checking for libXext... no
> > > configure: error: We need a working libXext to proceed. Since configure
> > > can't find it itself, we stop here assuming that make wouldn't find
> > > them either.
> >
> > I took the liberty of fixing this one too, it borrows a configure check
> > from KDE but only depends on QT.
>
> Thanks again for taking care of USE_KDELIBS_VER cases and for this one.
> There are a couple more of this type, like games/qgo, cad/qfsm... This is
> perhaps a naive question but would it be possible to put
> CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib
> --x-includes=${X11BASE}/include under USE_QT_VER section of bsd.kde.mk
> instead of under USE_KDELIBS_VER?
Not good, USE_QT_VER ports aren't guaranteed to use that configure check (or
even to use a configure script that understands or manages to gracefully
ignore these parameters).
> Or to even take it further and put it
> under .if defined(GNU_CONFIGURE) section in bsd.port.mk, perhaps depending
> on whether WITHOUT_X11 is defined?
That might work, but bsd.port.mk is portmgr territory, I can't touch it.
> It seems that would avoid the need to
> specify it in couple of ports separately.
There aren't that many US_QT_VER consumers in the tree which need those extra
CONFIGURE_ARGS - if you want, I could save you some donkey work, pick them
out of kris' error reports and commit the fixes myself.
--
,_, | Michael Nottebrock | lofi@freebsd.org
(/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org
\u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQBBtT6vXhc68WspdLARAgYHAJ4lRvHToMJ+2UKPfVE0XUfwQ2Eq4QCdGiKX
jLpiD25IaWBlkmVOrYIJCOg=
=a2Rk
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412070625.03222.michaelnottebrock>