From owner-cvs-all Fri May 18 7:12:28 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id DE7CA37B423; Fri, 18 May 2001 07:12:08 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f4IEBBa86305; Fri, 18 May 2001 17:11:11 +0300 (EEST) (envelope-from ru) Date: Fri, 18 May 2001 17:11:11 +0300 From: Ruslan Ermilov To: Brian Somers , Warner Losh , Bruce Evans , cvs-all@FreeBSD.ORG, current@FreeBSD.ORG, freebsd-arch@FreeBSD.ORG Subject: Re: Where to put include files (was: cvs commit: src Makefile.inc1) Message-ID: <20010518171110.D81893@sunbay.com> Mail-Followup-To: Brian Somers , Warner Losh , Bruce Evans , cvs-all@FreeBSD.ORG, current@FreeBSD.ORG, freebsd-arch@FreeBSD.ORG References: <200105171637.f4HGbsb65668@hak.lan.Awfulhak.org> <20010517195251.A90318@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010517195251.A90318@sunbay.com>; from ru@FreeBSD.org on Thu, May 17, 2001 at 07:52:51PM +0300 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, May 17, 2001 at 07:52:51PM +0300, Ruslan Ermilov wrote: [...] > > There are 59 Makefiles that have -I${.CURDIR}/(../)+sys in them. > All these are bogus. We should get rid of all of them (-I's). > > So far, I have found sbin/mount_* use headers from /sys/miscfs/ > that are not installed into /usr/include, but should be. Where > should these be installed? /usr/include/fs/ or > should we preserve the /usr/include/miscfs/ layout like in > /sys/miscfs? Modern fs'es install their headers into include/fs > and old ones in include/. > I have removed the -I${.CURDIR}/.../sys from the half of Makefiles that do not actually need it. Here is the rest of Makefiles that have the -I${.CURDIR}/.../sys in them, and it's currently required because they use headers from /sys that do not get installed into /usr/include (but should): sbin/atm/atm/Makefile sbin/atm/fore_dnld/Makefile sbin/atm/ilmid/Makefile sbin/mount_null/Makefile sbin/mount_portal/Makefile sbin/mount_umap/Makefile sbin/mount_union/Makefile sbin/vinum/Makefile usr.sbin/acpi/Makefile.inc very interesting example! usr.sbin/ancontrol/Makefile usr.sbin/dpt/dpt_ctlinfo/Makefile usr.sbin/dpt/dpt_ctls/Makefile usr.sbin/dpt/dpt_dm/Makefile usr.sbin/dpt/dpt_led/Makefile these even don't compile!!! usr.sbin/dpt/dpt_sig/Makefile usr.sbin/dpt/dpt_softc/Makefile usr.sbin/dpt/dpt_sysinfo/Makefile usr.sbin/mlxcontrol/Makefile usr.sbin/pciconf/Makefile usr.sbin/pnpinfo/Makefile usr.sbin/pstat/Makefile usr.sbin/raycontrol/Makefile usr.sbin/setkey/Makefile usr.sbin/sicontrol/Makefile Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message