Date: Wed, 06 Nov 2019 05:39:20 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 241751] [PATCH] security/sshguard: remove redundant pidfile check Message-ID: <bug-241751-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241751 Bug ID: 241751 Summary: [PATCH] security/sshguard: remove redundant pidfile check Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: delphij@FreeBSD.org CC: dan.mcgregor@usask.ca CC: dan.mcgregor@usask.ca Flags: maintainer-feedback?(dan.mcgregor@usask.ca) Created attachment 208906 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208906&action= =3Dedit Proposed patch The new SSHguard script performs an incomplete check of pidfile, which is n= ot needed on FreeBSD and can prevent the service from starting. The issue see= ms to be introduced by https://bitbucket.org/sshguard/sshguard/commits/32a4676599a900a7a072f66303d= 9c48b22d1107c Reproduction case: 1. echo "blah" > /var/run/sshguard.pid 2. service sshguard start Expected result: sshguard should start and write the PID. Actual result: sshguard won't start; if the command was executed manually, the user would = see "/var/run/sshguard.pid already exists; is SSHGuard already running?". Proposed patch attached. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241751-7788>