From owner-freebsd-net@FreeBSD.ORG Mon Sep 26 14:12:56 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA3221065672; Mon, 26 Sep 2011 14:12:56 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 542868FC0A; Mon, 26 Sep 2011 14:12:56 +0000 (UTC) Received: by vws11 with SMTP id 11so7303353vws.13 for ; Mon, 26 Sep 2011 07:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/L2b+pWbz3EuCVgwva7VIXTWcq4uRNxA535XIyN+7q4=; b=w4/2fYJQsYz5eU7qJn53VaJls+fhV5camZva0XyjBE2BhNAUK/UU98AUvUP1a/yCd7 hhDtmw7onuFIo6uI8bC3u6USvfzvUIhjaDcaVCuWL4ZsmpwZAnZ1XH23WPKTiy0GGrR9 ylIQ3LV6sL1cS4732Yi7lOJlysb38xeMoFtLE= MIME-Version: 1.0 Received: by 10.52.23.2 with SMTP id i2mr6551657vdf.412.1317046375295; Mon, 26 Sep 2011 07:12:55 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.52.113.202 with HTTP; Mon, 26 Sep 2011 07:12:55 -0700 (PDT) In-Reply-To: References: Date: Mon, 26 Sep 2011 16:12:55 +0200 X-Google-Sender-Auth: 05uOTlnDyD3iwXMrVtnE1s0fSjA Message-ID: From: "K. Macy" To: Arnaud Lacombe Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-net@freebsd.org" , Adrian Chadd , dave jones Subject: Re: Kernel panic on FreeBSD 9.0-beta2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2011 14:12:56 -0000 Sorry, didn't look at the images (limited bw), I've seen something like this before in timewait. This "can't happen" with UDP so will be interested in learning more about the bug. On Mon, Sep 26, 2011 at 4:02 PM, Arnaud Lacombe wrote: > Hi, > > On Mon, Sep 26, 2011 at 5:12 AM, K. Macy wrote: >> >> >> On Monday, September 26, 2011, Adrian Chadd wrote: >>> On 26 September 2011 13:41, Arnaud Lacombe wrote: >>>> =A0/* >>>> =A0 * XXX >>>> =A0 * This entire block sorely needs a rewrite. >>>> =A0 */ >>>> =A0 =A0 =A0 =A0if (t && >>>> =A0 =A0 =A0 =A0 =A0 =A0((t->inp_flags & INP_TIMEWAIT) =3D=3D 0) && >>>> =A0 =A0 =A0 =A0 =A0 =A0(so->so_type !=3D SOCK_STREAM || >>>> =A0 =A0 =A0 =A0 =A0 =A0 ntohl(t->inp_faddr.s_addr) =3D=3D INADDR_ANY) = && >>>> =A0 =A0 =A0 =A0 =A0 =A0(ntohl(sin->sin_addr.s_addr) !=3D INADDR_ANY || >>>> =A0 =A0 =A0 =A0 =A0 =A0 ntohl(t->inp_laddr.s_addr) !=3D INADDR_ANY || >>>> =A0 =A0 =A0 =A0 =A0 =A0 (t->inp_socket->so_options & >>>> =A0 =A0 =A0 =A0 =A0 SO_REUSEPORT) =3D=3D 0) && >>>> =A0 =A0 =A0 =A0 =A0 =A0(inp->inp_cred->cr_uid !=3D >>>> =A0 =A0 =A0 =A0 =A0 =A0 t->inp_cred->cr_uid)) >>>> =A0 =A0 =A0 =A0 =A0return (EADDRINUSE); >>>> =A0 =A0 =A0} >>>> >>>> more specifically, `t->inp_socket' is NULL. The top comment may not be >>>> relevant, as it's been here for the past 8 years. >>> >>> Why would t->inp_socket be NULL at this point? >> >> TIME_WAIT ... >> > on UDP socket ? > > =A0- Arnaud >