Date: Tue, 11 Dec 2001 22:07:03 -0500 From: Mike Tancsa <mike@sentex.net> To: Luigi Rizzo <rizzo@aciri.org> Cc: net@freebsd.org Subject: Re: Polling code at http://info.iet.unipi.it/~luigi/polling/ Message-ID: <5.1.0.14.0.20011211220210.046d3a88@192.168.0.12> In-Reply-To: <20011211161454.B23443@iguana.aciri.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, it looks like it patches OK, but when compiling, ruby3# make cc -c -x assembler-with-cpp -DLOCORE -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../i386/i386/locore.s cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 device_if.c cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 bus_if.c cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/fxp/if_fxp.c ../../dev/fxp/if_fxp.c: In function `fxp_intr': ../../dev/fxp/if_fxp.c:1198: `IFF_POLLING' undeclared (first use in this function) ../../dev/fxp/if_fxp.c:1198: (Each undeclared identifier is reported only once ../../dev/fxp/if_fxp.c:1198: for each function it appears in.) ../../dev/fxp/if_fxp.c: In function `fxp_init': ../../dev/fxp/if_fxp.c:1754: `IFF_POLLING' undeclared (first use in this function) *** Error code 1 Stop in /usr/src/sys/compile/ruby. ruby3# This is after a config -r, make depend etc... I do have options HZ=1000 options DEVICE_POLLING in my kernel config The patch seems to apply OK. ruby3# patch -p < stable.011210c.diffs Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/conf/options.i386 |=================================================================== |RCS file: /home/ncvs/src/sys/conf/options.i386,v |retrieving revision 1.132.2.10 |diff -u -r1.132.2.10 options.i386 |--- sys/conf/options.i386 8 Dec 2001 00:04:13 -0000 1.132.2.10 |+++ sys/conf/options.i386 11 Dec 2001 07:32:45 -0000 -------------------------- Patching file sys/conf/options.i386 using Plan A... Hunk #1 succeeded at 209 (offset 1 line). Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/fxp/if_fxp.c |=================================================================== |RCS file: /home/ncvs/src/sys/dev/fxp/if_fxp.c,v |retrieving revision 1.110.2.13 |diff -u -r1.110.2.13 if_fxp.c |--- sys/dev/fxp/if_fxp.c 8 Dec 2001 00:04:13 -0000 1.110.2.13 |+++ sys/dev/fxp/if_fxp.c 11 Dec 2001 07:32:46 -0000 -------------------------- Patching file sys/dev/fxp/if_fxp.c using Plan A... Hunk #1 succeeded at 170. Hunk #2 succeeded at 1150. Hunk #3 succeeded at 1192. Hunk #4 succeeded at 1227. Hunk #5 succeeded at 1282. Hunk #6 succeeded at 1746. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/i386/i386/swtch.s |=================================================================== |RCS file: /home/ncvs/src/sys/i386/i386/swtch.s,v |retrieving revision 1.89.2.6 |diff -u -r1.89.2.6 swtch.s |--- sys/i386/i386/swtch.s 8 Dec 2001 00:04:14 -0000 1.89.2.6 |+++ sys/i386/i386/swtch.s 11 Dec 2001 07:32:48 -0000 -------------------------- Patching file sys/i386/i386/swtch.s using Plan A... Hunk #1 succeeded at 246. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/i386/include/asnames.h |=================================================================== |RCS file: /home/ncvs/src/sys/i386/include/Attic/asnames.h,v |retrieving revision 1.44.2.5 |diff -u -r1.44.2.5 asnames.h |--- sys/i386/include/asnames.h 8 Dec 2001 00:04:14 -0000 1.44.2.5 |+++ sys/i386/include/asnames.h 11 Dec 2001 07:32:48 -0000 -------------------------- Patching file sys/i386/include/asnames.h using Plan A... Hunk #1 succeeded at 225. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/kern/kern_clock.c |=================================================================== |RCS file: /home/ncvs/src/sys/kern/kern_clock.c,v |retrieving revision 1.105.2.6 |diff -u -r1.105.2.6 kern_clock.c |--- sys/kern/kern_clock.c 8 Dec 2001 00:04:14 -0000 1.105.2.6 |+++ sys/kern/kern_clock.c 11 Dec 2001 07:32:49 -0000 -------------------------- Patching file sys/kern/kern_clock.c using Plan A... Hunk #1 succeeded at 67. Hunk #2 succeeded at 202. Hunk #3 succeeded at 255. Hunk #4 succeeded at 1035. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/net/netisr.h |=================================================================== |RCS file: /home/ncvs/src/sys/net/netisr.h,v |retrieving revision 1.21.2.3 |diff -u -r1.21.2.3 netisr.h |--- sys/net/netisr.h 4 Dec 2001 05:57:40 -0000 1.21.2.3 |+++ sys/net/netisr.h 11 Dec 2001 07:32:55 -0000 -------------------------- Patching file sys/net/netisr.h using Plan A... Hunk #1 succeeded at 61 (offset -1 lines). Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/pci/if_dc.c |=================================================================== |RCS file: /home/ncvs/src/sys/pci/if_dc.c,v |retrieving revision 1.9.2.30 |diff -u -r1.9.2.30 if_dc.c |--- sys/pci/if_dc.c 11 Dec 2001 03:02:48 -0000 1.9.2.30 |+++ sys/pci/if_dc.c 11 Dec 2001 07:32:56 -0000 -------------------------- Patching file sys/pci/if_dc.c using Plan A... Hunk #1 succeeded at 2319. Hunk #2 succeeded at 2634. Hunk #3 succeeded at 2698. Hunk #4 succeeded at 3049. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/pci/if_dcreg.h |=================================================================== |RCS file: /home/ncvs/src/sys/pci/if_dcreg.h,v |retrieving revision 1.4.2.13 |diff -u -r1.4.2.13 if_dcreg.h |--- sys/pci/if_dcreg.h 8 Dec 2001 00:04:15 -0000 1.4.2.13 |+++ sys/pci/if_dcreg.h 11 Dec 2001 07:32:56 -0000 -------------------------- Patching file sys/pci/if_dcreg.h using Plan A... Hunk #1 succeeded at 429. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/pci/if_sis.c |=================================================================== |RCS file: /home/ncvs/src/sys/pci/if_sis.c,v |retrieving revision 1.13.4.14 |diff -u -r1.13.4.14 if_sis.c |--- sys/pci/if_sis.c 8 Dec 2001 00:04:15 -0000 1.13.4.14 |+++ sys/pci/if_sis.c 11 Dec 2001 07:32:56 -0000 -------------------------- Patching file sys/pci/if_sis.c using Plan A... Hunk #1 succeeded at 1100. Hunk #2 succeeded at 1274. Hunk #3 succeeded at 1330. Hunk #4 succeeded at 1615. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/pci/if_sisreg.h |=================================================================== |RCS file: /home/ncvs/src/sys/pci/if_sisreg.h,v |retrieving revision 1.1.4.6 |diff -u -r1.1.4.6 if_sisreg.h |--- sys/pci/if_sisreg.h 8 Dec 2001 00:04:15 -0000 1.1.4.6 |+++ sys/pci/if_sisreg.h 11 Dec 2001 07:32:56 -0000 -------------------------- Patching file sys/pci/if_sisreg.h using Plan A... Hunk #1 succeeded at 402. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/sys/systm.h |=================================================================== |RCS file: /home/ncvs/src/sys/sys/systm.h,v |retrieving revision 1.111.2.12 |diff -u -r1.111.2.12 systm.h |--- sys/sys/systm.h 8 Dec 2001 00:04:16 -0000 1.111.2.12 |+++ sys/sys/systm.h 11 Dec 2001 07:32:56 -0000 -------------------------- Patching file sys/sys/systm.h using Plan A... Hunk #1 succeeded at 88. done ruby3# At 04:14 PM 12/11/2001 -0800, Luigi Rizzo wrote: >[Bcc to committers and -stable as relevant there, but >please keep the discussion on -net if any] > >I have put up a web page with the latest version of the device >polling patches, both for -stable and -current, at > > http://info.iet.unipi.it/~luigi/polling/ > >so new versions will be available through there, together with >additional documentation, code and references. > >Compared to the code recently pulled out from -stable, what you >can find now at the above URL has the following improvements: > > * "scheduling" code which lets you control in a reasonably > fine-grained way the sharing of CPU between kernel (polling) > and userland. You can now do something like > > sysctl kern.polling.user_frac=40 > > to reserve 40% of the CPU time to userland processes > (assuming there is enough work to do). Default value is 50. > > * a restructured polling loop which prevents livelock and > unfairness even when the standard (no fastforwarding) path > is used. > >Together with the kern.polling.enable variable, kern.polling.user_frac >is the only tunable parameter that you need to care about, and the >default value should be a reasonable one. > >It would be great if some of you committers would have the time to >have a look at the -current version, or possibly even try it on >Alpha boxes (I think overall there is only one or two lines of MD >code), and send feedback. > > thanks > luigi >----------------------------------+----------------------------------------- > Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) > http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 > Phone: (510) 666 2927 >----------------------------------+----------------------------------------- > >To Unsubscribe: send mail to majordomo@FreeBSD.org >with "unsubscribe freebsd-stable" in the body of the message -------------------------------------------------------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet since 1994 www.sentex.net Cambridge, Ontario Canada www.sentex.net/mike To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5.1.0.14.0.20011211220210.046d3a88>