From owner-cvs-all Mon May 11 00:48:18 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA28993 for cvs-all-outgoing; Mon, 11 May 1998 00:48:18 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA28984 for ; Mon, 11 May 1998 00:48:15 -0700 (PDT) (envelope-from dag-erli@ifi.uio.no) Received: from hrotti.ifi.uio.no (2602@hrotti.ifi.uio.no [129.240.64.15]) by ifi.uio.no (8.8.8/8.8.7/ifi0.2) with ESMTP id JAA20139; Mon, 11 May 1998 09:48:14 +0200 (MET DST) Received: (from dag-erli@localhost) by hrotti.ifi.uio.no ; Mon, 11 May 1998 09:48:14 +0200 (MET DST) Mime-Version: 1.0 To: "Jordan K. Hubbard" Cc: committers@FreeBSD.ORG Subject: Re: libfetch References: <8844.894856719@time.cdrom.com> Organization: Gutteklubben Terrasse / KRST / PUMS / YASMW X-url: http://www.stud.ifi.uio.no/~dag-erli/ X-Stop-Spam: http://www.cauce.org From: dag-erli@ifi.uio.no (Dag-Erling Coidan =?iso-8859-1?Q?Sm=F8rgrav?= ) Date: 11 May 1998 09:48:13 +0200 In-Reply-To: "Jordan K. Hubbard"'s message of "Sun, 10 May 1998 20:18:39 -0700" Message-ID: Lines: 38 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Jordan K. Hubbard" writes: > 1. I don't suppose you could switch to something along the lines of K&R > or KNF (style(9)) formatting for this code before it gets too much > larger? I don't really like it much, but I guess it won't kill me :) The funny thing is that once upon a time when I was a believer of Wirth, I used to put my BEGINs at the end of the controlling line, but now that I have become an advocate of Ritchie and Thompson, i put my {s below the controlling line :) > 2. I thought that fetchFooURL() would take an extra arg for setting > connection behavior? How do I do a fetchFooURL() with FTP passive > mode set or tell the file:/ stuff to symlink instead of copying, for > example? Not Yet Implemented :) but I got a very good suggestion yesterday from Mike Smith (option strings as in fopen()), so I'll cook something up soon. I pulled out all the "int flags" arguments because I realized they wouldn't be much help (too few bits, as you pointed out) > 3. Unless this is a complete from-scratch work (in which case, more > power to ya!) you might think of crediting folks like Bill Fenner > in the copyrights for anything you've derived from their work, just > to be a nice guy. :) I did write it completely from scratch, because I didn't quite see how I could easily extract the http code from fetch. The approach is completely different; fetch knows it is going to write the file directly to disk, whereas I must provide a stream which will allow the caller to read the file directly from the server as if it were a file on disk, and I have to do that transparently (i.e. decode chunk-coded data on the fly). I did look at the fetch code, but only to understand how the protocol works, since RFC2068 is not one of the better-written RFCs. -- Noone else has a .sig like this one. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message