From nobody Tue Dec 16 23:43:25 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dWD5T4QFtz6LPd6 for ; Tue, 16 Dec 2025 23:43:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dWD5T2SFlz3Gqs for ; Tue, 16 Dec 2025 23:43:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765928605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=77sERJYMqx5yJczTa636EDla2DbQzgo8D6ccUEWvJRo=; b=Cpab2wwRF5Q/ewr6+cT2WSm7+Y6K1YdUcRkR1oI0u+KJoMd+E5/xJ6Aw5FYmEWXX/mTwjf XCfBPmk6ZggmOluzOzZatVC+AcOXD6GyqUWQYc1bTyQ3z9zq+MBmP2Fn42ZbuukMS0KObQ 2jKkQNnk4k2N2afdAdlMg1Fv2JOa5MuOpbS+TSZRL0rEM0vSrx99+Ph80zSnDYJJjJbHYg ZkXP5pGjzlEVz9EVjOSmLuE0WAQjjT2qaGjGMgiJmhmuGVI9ZTioiIU6aLu6Qy9Qj0ahnz MzJDDhVQ7Ce9wpD8TCdIMjV/ZLSgSDZmwsKgur7BPIhVCOvSWsLrGkyI3Hqs/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765928605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=77sERJYMqx5yJczTa636EDla2DbQzgo8D6ccUEWvJRo=; b=hYAhkLS7wXaupLerGBv0kqScUlkQLxaMLqT88UFe8+ykkfgJdqbR2svLSqZpjACsvpHUP3 YCv5FMT9T9269Xn7Rzsa6DYwqjpAThqBOWD2J6pOgZCtpnopSTpifCOK9VQGohKdtTutpN l2X9ZPJDPSRUvw7nHT1fT4JEj8b4kIjLKAVJtMPXQfdW5k7IiXNLa8H92BCK+HoqbFmHp2 kqznj3rh8ZlwHUD8SoH9dGBKBO50YJCA5c+8MVjlZInErfactxi/V2+lSYGegqXOx/Yd4Q OOaBwFimfwo8A9GmrZPAi0b7/vNjyGSqhzbwILwbmCQSWZLo96y3G7n4FDJu/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765928605; a=rsa-sha256; cv=none; b=KREDxMkcmQ9xwWlkQQdkh6cBPUum/yyR5k61a2Hn1as53XjgpMaoSPEUkvxQ4641O1AjSI TNGqW279H+koKfRtZ8i+gdw/Ed2dyv57Ed8BJQP8y+feaoV43Wl1L2+4ErchTMGPc3e4Qt 8uZhLIHRtvRWJ578Va8ByDXJdoTGKcQPSvzHMcrm34n/OubFQ2vQ6JH9+UlwpVqGqXmK+r 8I9BvN8EMTirdwFfv0127Afwv3OZaz7urx8lxT7LQ6w2yoIoQE2I/S7fKNbcMBuaULEa6o MGerwhmF/f28i5yu5B5LMtkvpzSx+CMooVfCUAMdzyaN4M/WSyWq/2AFSXuUvw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dWD5T20CFzCS2 for ; Tue, 16 Dec 2025 23:43:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23dad by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 16 Dec 2025 23:43:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 3c54b204bf86 - releng/14.3 - rtsold: Validate entries in domain search lists List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: 3c54b204bf86dc6c84b72c3fe8820d0ce25cb354 Auto-Submitted: auto-generated Date: Tue, 16 Dec 2025 23:43:25 +0000 Message-Id: <6941ee9d.23dad.148278e4@gitrepo.freebsd.org> The branch releng/14.3 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3c54b204bf86dc6c84b72c3fe8820d0ce25cb354 commit 3c54b204bf86dc6c84b72c3fe8820d0ce25cb354 Author: Mark Johnston AuthorDate: 2025-12-15 20:50:08 +0000 Commit: Mark Johnston CommitDate: 2025-12-16 23:41:02 +0000 rtsold: Validate entries in domain search lists Reported by: Kevin Day Approved by: so Security: FreeBSD-SA-25:12.rtsold Security: CVE-2025-14558 --- usr.sbin/rtsold/rtsol.c | 46 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 40 insertions(+), 6 deletions(-) diff --git a/usr.sbin/rtsold/rtsol.c b/usr.sbin/rtsold/rtsol.c index 79928932ca5c..a7d5a44a7d44 100644 --- a/usr.sbin/rtsold/rtsol.c +++ b/usr.sbin/rtsold/rtsol.c @@ -776,6 +776,41 @@ call_script(const char *const argv[], struct script_msg_head_t *sm_head) argv[0], status); } +#define PERIOD 0x2e +#define hyphenchar(c) ((c) == 0x2d) +#define periodchar(c) ((c) == PERIOD) +#define alphachar(c) (((c) >= 0x41 && (c) <= 0x5a) || \ + ((c) >= 0x61 && (c) <= 0x7a)) +#define digitchar(c) ((c) >= 0x30 && (c) <= 0x39) + +#define borderchar(c) (alphachar(c) || digitchar(c)) +#define middlechar(c) (borderchar(c) || hyphenchar(c)) + +static int +res_hnok(const char *dn) +{ + int pch = PERIOD, ch = *dn++; + + while (ch != '\0') { + int nch = *dn++; + + if (periodchar(ch)) { + ; + } else if (periodchar(pch)) { + if (!borderchar(ch)) + return (0); + } else if (periodchar(nch) || nch == '\0') { + if (!borderchar(ch)) + return (0); + } else { + if (!middlechar(ch)) + return (0); + } + pch = ch, ch = nch; + } + return (1); +} + /* Decode domain name label encoding in RFC 1035 Section 3.1 */ static size_t dname_labeldec(char *dst, size_t dlen, const char *src) @@ -804,12 +839,11 @@ dname_labeldec(char *dst, size_t dlen, const char *src) } *dst = '\0'; - /* - * XXX validate that domain name only contains valid characters - * for two reasons: 1) correctness, 2) we do not want to pass - * possible malicious, unescaped characters like `` to a script - * or program that could be exploited that way. - */ + if (!res_hnok(dst_origin)) { + warnmsg(LOG_INFO, __func__, + "invalid domain name '%s' was ignored", dst_origin); + return (0); + } return (src - src_origin); }