From owner-svn-src-head@FreeBSD.ORG Thu May 21 16:38:52 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A7AE1065674; Thu, 21 May 2009 16:38:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 247808FC1F; Thu, 21 May 2009 16:38:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1M7BI9-000Jl4-KT; Thu, 21 May 2009 19:38:49 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n4LGckxo032269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 May 2009 19:38:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n4LGckLt074218; Thu, 21 May 2009 19:38:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n4LGckL2074166; Thu, 21 May 2009 19:38:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 21 May 2009 19:38:46 +0300 From: Kostik Belousov To: Scott Long Message-ID: <20090521163846.GT1927@deviant.kiev.zoral.com.ua> References: <3bbf2fe10905210629p46c7a204v6863aaba77354462@mail.gmail.com> <20090521.094100.70797067.imp@bsdimp.com> <4A157919.7040103@samsco.org> <200905211211.00168.jhb@freebsd.org> <20090521161535.GQ1927@deviant.kiev.zoral.com.ua> <4A157FF3.8020408@samsco.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d5xRKMqY7hkGAt+u" Content-Disposition: inline In-Reply-To: <4A157FF3.8020408@samsco.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.1 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1M7BI9-000Jl4-KT bd1b9462554b34ecbc88e2123637bb3d X-Terabit: YES Cc: src-committers@freebsd.org, John Baldwin , svn-src-all@freebsd.org, attilio@freebsd.org, rwatson@freebsd.org, svn-src-head@freebsd.org, "M. Warner Losh" Subject: Re: svn commit: r192535 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2009 16:38:53 -0000 --d5xRKMqY7hkGAt+u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 21, 2009 at 09:23:15AM -0700, Scott Long wrote: > Kostik Belousov wrote: > >We do have the KPI for the callers that cannot drop the locks and need > >to do destroy_dev, destroy_dev_sched(9). >=20 > Good to know, I'll look at destroy_dev_sched(). I'd rather not have to > roll my own decoupled version. And I understand the argument about > destroy_dev being a drain point for the API. However, what about > create_dev()? Making that non-blocking would help a lot. create_dev() can be made non-blocking, and this is the first argument pro Attilio patch. =46rom the quick look, all that is needed is to replace M_WAITOK with M_NOWAIT inside prep_cdevsw() and devfs_alloc(). Untested patch below. diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c index 4041911..f470ee8 100644 --- a/sys/fs/devfs/devfs_devs.c +++ b/sys/fs/devfs/devfs_devs.c @@ -120,7 +120,7 @@ devfs_alloc(void) struct cdev *cdev; struct timespec ts; =20 - cdp =3D malloc(sizeof *cdp, M_CDEVP, M_USE_RESERVE | M_ZERO | M_WAITOK); + cdp =3D malloc(sizeof *cdp, M_CDEVP, M_USE_RESERVE | M_ZERO | M_NOWAIT); =20 cdp->cdp_dirents =3D &cdp->cdp_dirent0; cdp->cdp_dirent0 =3D NULL; diff --git a/sys/kern/kern_conf.c b/sys/kern/kern_conf.c index 284f482..acdd44a 100644 --- a/sys/kern/kern_conf.c +++ b/sys/kern/kern_conf.c @@ -559,7 +559,7 @@ prep_cdevsw(struct cdevsw *devsw) return; if (devsw->d_flags & D_NEEDGIANT) { dev_unlock(); - dsw2 =3D malloc(sizeof *dsw2, M_DEVT, M_WAITOK); + dsw2 =3D malloc(sizeof *dsw2, M_DEVT, M_NOWAIT); dev_lock(); } else dsw2 =3D NULL; --d5xRKMqY7hkGAt+u Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkoVg5UACgkQC3+MBN1Mb4gjKgCg8S3EaQZX3mKrL95vcj9m2Pgy 18kAoIsgBfEGPBrUSxw+nOaX7+xQrtBO =kPkC -----END PGP SIGNATURE----- --d5xRKMqY7hkGAt+u--