From owner-freebsd-x11@freebsd.org Wed Jan 13 21:35:09 2016 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62898A81421 for ; Wed, 13 Jan 2016 21:35:09 +0000 (UTC) (envelope-from naddy@mips.inka.de) Received: from mail.inka.de (quechua.inka.de [IPv6:2001:7c0:407:1001:217:a4ff:fe3b:e77c]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2EEBB1617 for ; Wed, 13 Jan 2016 21:35:09 +0000 (UTC) (envelope-from naddy@mips.inka.de) Received: from mips.inka.de (naddy@[127.0.0.1]) by mail.inka.de with uucp (rmailwrap 0.5) id 1aJT4N-0007R9-3d; Wed, 13 Jan 2016 22:35:07 +0100 Received: from lorvorc.mips.inka.de (localhost [127.0.0.1]) by lorvorc.mips.inka.de (8.15.2/8.15.2) with ESMTP id u0DLVJNe017568 for ; Wed, 13 Jan 2016 22:31:19 +0100 (CET) (envelope-from naddy@lorvorc.mips.inka.de) Received: (from naddy@localhost) by lorvorc.mips.inka.de (8.15.2/8.15.2/Submit) id u0DLVITh017567 for freebsd-x11@freebsd.org; Wed, 13 Jan 2016 22:31:19 +0100 (CET) (envelope-from naddy) Date: Wed, 13 Jan 2016 22:31:18 +0100 From: Christian Weisgerber To: freebsd-x11@freebsd.org Subject: x11/luit: fix ^V bug Message-ID: <20160113213118.GA17323@lorvorc.mips.inka.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 21:35:09 -0000 luit(1) fails to make its tty fully transparent and accidentally leaves lnext (^V) processing enabled. One way to discover this: Start xterm with an ISO8859-2 locale, which will automatically start luit. Start an Emacs-style editor, try to page down with ^V. Notice that you need to enter ^V^V. I think the luit author assumed that switching off ICANON would disable this kind of input processing, as it does on Linux, but on BSD, LNEXT is explicitly outside ICANON and only governed by IEXTEN. I would like to commit this straightforward fix. Any objections? (I've also talked to Matthieu Herrb of X.org who will get this upstream.) Index: Makefile =================================================================== --- Makefile (revision 406068) +++ Makefile (working copy) @@ -2,6 +2,7 @@ PORTNAME= luit PORTVERSION= 1.1.1 +PORTREVISION= 1 CATEGORIES= x11 MAINTAINER= x11@FreeBSD.org Index: files/patch-sys.c =================================================================== --- files/patch-sys.c (revision 0) +++ files/patch-sys.c (working copy) @@ -0,0 +1,11 @@ +--- sys.c.orig 2012-03-23 04:23:07 UTC ++++ sys.c +@@ -256,7 +256,7 @@ setRawTermios(void) + rc = tcgetattr(0, &tio); + if (rc < 0) + return rc; +- tio.c_lflag &= (unsigned) ~(ECHO | ICANON | ISIG); ++ tio.c_lflag &= (unsigned) ~(ECHO | ICANON | IEXTEN | ISIG); + tio.c_iflag &= (unsigned) ~(ICRNL | IXOFF | IXON | ISTRIP); + #ifdef ONLCR + tio.c_oflag &= (unsigned) ~ONLCR; Property changes on: files/patch-sys.c ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property -- Christian "naddy" Weisgerber naddy@mips.inka.de