From owner-svn-ports-all@freebsd.org Tue Jun 19 07:09:31 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEB78100176A; Tue, 19 Jun 2018 07:09:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E9D36F675; Tue, 19 Jun 2018 07:09:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id VAlWfHhcGSzNNVAlXfNL13; Tue, 19 Jun 2018 01:09:23 -0600 X-Authority-Analysis: v=2.3 cv=KuxjJ1eN c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=7mUfYlMuFuIA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=kflrSwzHNs2BWWs0MjEA:9 a=NGPWxmDp93m3Zp8Z:21 a=7wwcKriNZYnhriRP:21 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 15F3F26D; Tue, 19 Jun 2018 00:09:22 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w5J79LYn026010; Tue, 19 Jun 2018 00:09:21 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w5J79LOw026007; Tue, 19 Jun 2018 00:09:21 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201806190709.w5J79LOw026007@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r472762 - in head/security/krb5-devel: . files In-Reply-To: Message from Cy Schubert of "Tue, 19 Jun 2018 06:56:12 -0000." <201806190656.w5J6uC57084388@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 19 Jun 2018 00:09:21 -0700 X-CMAE-Envelope: MS4wfIMeuqPXetJ6HPeVmM/AGWiqBe86Oryg+cnZF235E72Gh5dkOAeGVcbmso/+HfpQh9FEu+pP7AAPLc5ivhkaJwegxCEuE/TvlhxvAWdUKERyM0KhozpA 2aCRS3j4UJ01z5q/mgYizyXWkAYrBx3PApuIXCjGRKZqsMRDntm7MqqZc9wTxR/dnvAKoBvZ+GjuREtrKzPAepayIjwT1zdYvTsiatN3CsvYt6xmDUlt7eDC YW4aXbeok7jI4QLIaUHNIJa0sjKIxOLooU68J8hi4PzXJsO79M7l0WH1nfUadF57MlIsIOINA7Fh60Q6dZNSJw== X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 07:09:31 -0000 In message <201806190656.w5J6uC57084388@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Tue Jun 19 06:56:12 2018 > New Revision: 472762 > URL: https://svnweb.freebsd.org/changeset/ports/472762 > > Log: > As described in r472760, the "register" keyword is meaningless and > causes at least one port some gas. Remove the keyword from krb5.h. > > Added: > head/security/krb5-devel/files/patch-include_krb5_krb5.hin (contents, pro > ps changed) > Modified: > head/security/krb5-devel/Makefile > > Modified: head/security/krb5-devel/Makefile > ============================================================================= > = > --- head/security/krb5-devel/Makefile Tue Jun 19 06:52:44 2018 (r47276 > 1) > +++ head/security/krb5-devel/Makefile Tue Jun 19 06:56:12 2018 (r47276 > 2) > @@ -3,7 +3,7 @@ > > PORTNAME= krb5 > PORTVERSION= 1.17.${MIT_COMMIT_DATE} > -PORTREVISION= 1 > +PORTREVISION= 2 > CATEGORIES= security > .if !defined(MASTERDIR) > PKGNAMESUFFIX= -devel > > Added: head/security/krb5-devel/files/patch-include_krb5_krb5.hin > ============================================================================= > = > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/security/krb5-devel/files/patch-include_krb5_krb5.hin Tue Jun > 19 06:56:12 2018 (r472762) > @@ -0,0 +1,74 @@ > +--- include/krb5/krb5.hin.orig 2018-05-12 22:15:24.000000000 -0700 > ++++ include/krb5/krb5.hin 2018-06-18 23:46:02.119491000 -0700 > +@@ -3566,7 +3566,7 @@ > + */ > + krb5_error_code KRB5_CALLCONV > + krb5_unparse_name(krb5_context context, krb5_const_principal principal, > +- register char **name); > ++ char **name); > + > + /** > + * Convert krb5_principal structure to string and length. > +@@ -4389,7 +4389,7 @@ > + */ > + krb5_error_code KRB5_CALLCONV_WRONG > + krb5_principal2salt(krb5_context context, > +- register krb5_const_principal pr, krb5_data *ret); > ++ krb5_const_principal pr, krb5_data *ret); > + /* librc.spec--see rcache.h */ > + > + /* libcc.spec */ > +@@ -4730,7 +4730,7 @@ > + * This function frees the contents of @a val and the structure itself. > + */ > + void KRB5_CALLCONV > +-krb5_free_error(krb5_context context, register krb5_error *val); > ++krb5_free_error(krb5_context context, krb5_error *val); > + > + /** > + * Free a krb5_creds structure. > +@@ -4763,7 +4763,7 @@ > + * This function frees the contents of @a val and the structure itself. > + */ > + void KRB5_CALLCONV > +-krb5_free_checksum(krb5_context context, register krb5_checksum *val); > ++krb5_free_checksum(krb5_context context, krb5_checksum *val); > + > + /** > + * Free the contents of a krb5_checksum structure. > +@@ -4774,7 +4774,7 @@ > + * This function frees the contents of @a val, but not the structure itself > . > + */ > + void KRB5_CALLCONV > +-krb5_free_checksum_contents(krb5_context context, register krb5_checksum *v > al); > ++krb5_free_checksum_contents(krb5_context context, krb5_checksum *val); > + > + /** > + * Free a krb5_keyblock structure. > +@@ -4785,7 +4785,7 @@ > + * This function frees the contents of @a val and the structure itself. > + */ > + void KRB5_CALLCONV > +-krb5_free_keyblock(krb5_context context, register krb5_keyblock *val); > ++krb5_free_keyblock(krb5_context context, krb5_keyblock *val); > + > + /** > + * Free the contents of a krb5_keyblock structure. > +@@ -4796,7 +4796,7 @@ > + * This function frees the contents of @a key, but not the structure itself > . > + */ > + void KRB5_CALLCONV > +-krb5_free_keyblock_contents(krb5_context context, register krb5_keyblock *k > ey); > ++krb5_free_keyblock_contents(krb5_context context, krb5_keyblock *key); > + > + /** > + * Free a krb5_ap_rep_enc_part structure. > +@@ -4912,7 +4912,7 @@ > + * Kerberos error codes > + */ > + krb5_error_code KRB5_CALLCONV > +-krb5_timeofday(krb5_context context, register krb5_timestamp *timeret); > ++krb5_timeofday(krb5_context context, krb5_timestamp *timeret); > + > + /** > + * Check if a timestamp is within the allowed clock skew of the current tim > e. Updating the -devel port to the latest commit I discovered that our upline was thinking the same. They removed the "register" keyword from krb5.h and a number of other files as well. I will backport the complete patch to the remaining krb5 ports after krb5-devel is updated (probably tomorrow). It's been serendipitous on more than one occasion today. Given that it's past midnight here, the update to krb5-devel will have to wait. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.