From owner-svn-ports-all@freebsd.org Tue Sep 18 14:00:45 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9AE2A109EE54; Tue, 18 Sep 2018 14:00:45 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 512CA71B42; Tue, 18 Sep 2018 14:00:45 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4C27420DA0; Tue, 18 Sep 2018 14:00:45 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w8IE0jA0041478; Tue, 18 Sep 2018 14:00:45 GMT (envelope-from emaste@FreeBSD.org) Received: (from emaste@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w8IE0jtH041477; Tue, 18 Sep 2018 14:00:45 GMT (envelope-from emaste@FreeBSD.org) Message-Id: <201809181400.w8IE0jtH041477@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: emaste set sender to emaste@FreeBSD.org using -f From: Ed Maste Date: Tue, 18 Sep 2018 14:00:45 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r480024 - head/multimedia/libx264 X-SVN-Group: ports-head X-SVN-Commit-Author: emaste X-SVN-Commit-Paths: head/multimedia/libx264 X-SVN-Commit-Revision: 480024 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 14:00:45 -0000 Author: emaste (src committer) Date: Tue Sep 18 14:00:44 2018 New Revision: 480024 URL: https://svnweb.freebsd.org/changeset/ports/480024 Log: multimedia/libx264: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_PC32 against symbol: gettimeofday in readonly segment; recompile object files with -fPIC This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. PR: 214864, 230214 Reviewed by: koobs Approved by: koobs Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17201 Modified: head/multimedia/libx264/Makefile Modified: head/multimedia/libx264/Makefile ============================================================================== --- head/multimedia/libx264/Makefile Tue Sep 18 13:57:03 2018 (r480023) +++ head/multimedia/libx264/Makefile Tue Sep 18 14:00:44 2018 (r480024) @@ -14,6 +14,9 @@ LIB_DEPENDS= # USES= pathfix +LDFLAGS+= ${LDFLAGS_${ARCH}} +LDFLAGS_i386= -Wl,-znotext + OPTIONS_DEFINE= ASM OPENCL OPTIONS_DEFAULT= ASM OPENCL OPTIONS_EXCLUDE= FFMS GPAC LAVF LSMASH SWSCALE