From owner-freebsd-current  Sat May 15 17:13:52 1999
Delivered-To: freebsd-current@freebsd.org
Received: from bubba.whistle.com (s205m7.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP id 3A43F150F3
	for <freebsd-current@FreeBSD.org>; Sat, 15 May 1999 17:13:50 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.2/8.9.2) id RAA04068;
	Sat, 15 May 1999 17:08:25 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199905160008.RAA04068@bubba.whistle.com>
Subject: Re: Skip fail under current, was: Re: VPN betwwen Windows 9x Clients and FreeBSD Firewall
In-Reply-To: <19502.926767996@critter.freebsd.dk> from Poul-Henning Kamp at "May 15, 99 01:33:16 pm"
To: phk@critter.freebsd.dk (Poul-Henning Kamp)
Date: Sat, 15 May 1999 17:08:24 -0700 (PDT)
Cc: leifn@neland.dk, bob@dnsdata.com, freebsd-current@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Poul-Henning Kamp writes:
> >It won't compile under current.
> >freebsd/skip_es.c breaks at
> >
> >	if (suser(p->p_ucred, &p->p_acflag )) {
> >
> >This won't compile, because suser only has one parameter.
> >
> >Trying blindly to change it to: 
> >
> >	if (suser(p->p_ucred)) {
> 
> Better yet, read the manpage for suser(9) and change it to:
> 
> 	if (suser(p)) {

Thanks for noticing this. I'll fix it as soon as the ports freeze is over.
For the sake of 3.x systems, I'll change it to this..

    #if __FreeBSD_version < 400005
	    if (suser(p->p_ucred, &p->p_acflag )) {
    #else
	    if (suser(p)) {
    #endif
		    return (EPERM);
	    }

Poul, thanks for bumping __FreeBSD_version when the suser() changes
went through :-)

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message