From owner-dev-commits-src-main@freebsd.org Wed Mar 3 23:45:18 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F092955525F; Wed, 3 Mar 2021 23:45:18 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DrVwt6BYgz3nDS; Wed, 3 Mar 2021 23:45:18 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x62f.google.com with SMTP id d11so14982652plo.8; Wed, 03 Mar 2021 15:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=N/emB/1YFsG2Bim1x0jlMiiCyVHQVS4Dqw7P70AKORk=; b=WoBPzNkcEDYARXpi7jS4lsFqZpUV0nEoY42dlVcw1yVj3EDtaAgMEwRxa2llJzf7dF +hOb0yt+P2eE4/Yr5alg55xEGpn0FteleOKPZdR6npm/G1TuKfzDbYACb2cSsreArIFF YxJ6qynE12Laov0TiHx5+G347vOIPyn6G01TUjE9rhlWISbTnLPngxAqJJE1I6rJfjNq 7Yyn8Rc2Z4HHovfY2KezzWIn975x6EFCYKdA49q3iVpoB8EFjr1K1ZY7xchfa7G932iQ BdW0djFF0qIu2gTZKED06tbCTCVRZIzDYwTSOswxGz/qmA6HJT/EADEsmIvaC+rE3Jp7 +Tew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=N/emB/1YFsG2Bim1x0jlMiiCyVHQVS4Dqw7P70AKORk=; b=W/1pjryuA3h3VHabYiUABfhxdEF8bIt75t2T6Xl09AkCucrzpaHc05trQ1SvBE9yku 3X2a315CORMbRqBowxt+bvlothTtP6vFnHkWKm6z6Tavj4rKTg0HY8ZSoesuK/tFsXhG t14+V3+Pye54iCcaastZH/B/BZFYZyXYDq2qM1Y2/T9DAqwoKiq3CAZsBayrdAOUQPil wqxfaaPIWxY2oHY6wo5YViIZCJsA3tud7vF7kEhHC96KwZouh8Q5I8WBPdRMmveH7zds FhGeDFawUoePKGa0a8w6bCtMWGY8gHTHcCRhA+H/YDqnH6WZm5WLkXaQJxWYTpp/xVyy rfWw== X-Gm-Message-State: AOAM531HMYVR0RNvpMOtjGQ9RzcqGUX4C7FZkQSvxUuUAJKyFzbi7jC3 yPm8xkDT7Cu6Jy8ItiNltyIgV3SPfVU= X-Google-Smtp-Source: ABdhPJzXZBw+mavc57fSyUA0ozyvBteEIDNp43LIArXfwwmvKf/FO4fbiR2GAVSm3BcLAmogdyXxYA== X-Received: by 2002:a17:90a:1696:: with SMTP id o22mr1493447pja.0.1614815117036; Wed, 03 Mar 2021 15:45:17 -0800 (PST) Received: from localhost (167-179-159-58.a7b39f.syd.nbn.aussiebb.net. [167.179.159.58]) by smtp.gmail.com with UTF8SMTPSA id d19sm1232998pjs.55.2021.03.03.15.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Mar 2021 15:45:16 -0800 (PST) Sender: Kubilay Kocak Message-ID: <2c9e447a-d139-fb48-d9b5-85bfae1ff30f@FreeBSD.org> Date: Thu, 4 Mar 2021 10:45:11 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Thunderbird/88.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: git: 55deb0a5f089 - main - service(8): use an environment more consistent with init(8) Content-Language: en-US To: Kyle Evans , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202103031828.123ISTI5001652@gitrepo.freebsd.org> From: Kubilay Kocak In-Reply-To: <202103031828.123ISTI5001652@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DrVwt6BYgz3nDS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 23:45:19 -0000 On 4/03/2021 5:28 am, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=55deb0a5f089c8a27cfc1666655b93881c2b47ae > > commit 55deb0a5f089c8a27cfc1666655b93881c2b47ae > Author: Andrew Gierth > AuthorDate: 2021-03-03 18:25:11 +0000 > Commit: Kyle Evans > CommitDate: 2021-03-03 18:25:11 +0000 > > service(8): use an environment more consistent with init(8) > > init(8) sets the "daemon" login class without specifying a pw > entry (so no substitutions are done on the variables). service(8)'s > use of env -L had the effect of specifying root's pw entry, with two > effects: getpwnam and getpwuid are being called, which may not be > entirely safe depending on what nsswitch is up to and what stage of > boot we are at, and substitutions would have been done. > > Fix by teaching env(8) to allow -L -/classname to set the class > environment with no pw entry at all specified, and use it in > service(8). > > PR: 253959 Is MFC'able to stable/* or might there be backward compatibility issue?