From owner-svn-ports-all@FreeBSD.ORG Mon Aug 25 14:06:37 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2E990C6F; Mon, 25 Aug 2014 14:06:37 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 73E6B3F48; Mon, 25 Aug 2014 14:06:36 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 4F30373012; Mon, 25 Aug 2014 10:06:34 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r365735 - in head/games: . prboom-plus From: Adam Weinberger In-Reply-To: <53FB4122.3060402@marino.st> Date: Mon, 25 Aug 2014 10:06:33 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <30BF3C98-F800-406C-AAEF-6FC3E0ABF01C@adamw.org> References: <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org> <53FB3FB3.90508@marino.st> <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org> <53FB4122.3060402@marino.st> To: marino@freebsd.org X-Mailer: Apple Mail (2.1878.6) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Adam Weinberger , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 14:06:37 -0000 On 25 Aug, 2014, at 9:58, John Marino wrote: > On 8/25/2014 15:55, Adam Weinberger wrote: >> On 25 Aug, 2014, at 9:52, John Marino = wrote: >>=20 >>> On 8/25/2014 15:43, Adam Weinberger wrote: >>>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev >>>> wrote: >>>>> COMMENT line is wrong. :) >>>>=20 >>>> Because it starts with an article? I=92d posit that that article >>>> improves readability of this particular COMMENT. >>>=20 >>> Yes, because it starts with an article. We've been instructed to >>> remove them unconditionally. >>> Hundreds of ports have comments equivalent to "Fork of the doom game >>> engine prboom", so it's not special in any way. >>>=20 >>> Unfortunately portlint doesn't check for this. I'd add this to the >>> current catch-all portlint rule PR. >>=20 >> Guys, if it=92s not right, please just fix it! >>=20 >=20 > It's more than that -- Let's say you really think starting with "A " = is > essential not matter what the rule is, then it makes sense to discuss = it > to prevent it in the future. It's not being lazy or critical, it's > educating. At least I believe that is the intent. I have worked quite hard the last few days to commit all staging PRs, = clear out nearly every patch-ready PR, and a lot of other PRs too. I = missed one article in one COMMENT. I missed it because it read quite = clearly. But sure, please re-educate me. Clearly I believe that adding articles = is essential no matter what the rule is. You discovered my secret = subversive mission. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org