From owner-svn-src-head@freebsd.org Fri Jul 3 01:21:07 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 57831364B2A; Fri, 3 Jul 2020 01:21:07 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49ycc26vZqz4VlM; Fri, 3 Jul 2020 01:21:06 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f170.google.com with SMTP id s1so14678642ybo.7; Thu, 02 Jul 2020 18:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v1R+pE5brkQucsvxSb2fDW8kPLQPqE9/bNGoTxwCwDk=; b=FUqyhrMfRJ92h1t99keNV+F39Cl1F357/azXljZZflnleGqdMQsE1uqC4m0lGkfzQK jlZVSeYyR3wJt5QFNSN77BvXI2b4pIR0AvdsGpSEhN+imyJ3p7n/H/siHmLqbkz65Nzn jeJ+BXAmKvx4LFrf2ArGVp4Z99pXAlqN/068s24rLA0XRxvrnqbIN6I+HakoHsVv0nOq CUgDUUFa01KVVc0cWBdBQt0wBbOpx/OUGt7ckmJeJDxX3d4H55/1GHcMFm2b/iFvFbah y1eZ205ryIAalu3HDUnMrmhMQM1sXm0RZzQK9aPOhH9dtZIVyGBrksw29RJ+kWbRyDyJ gmfg== X-Gm-Message-State: AOAM530SD6sshTd2mlDDPRlQVfii/x81cErDt/x+Hztt9Jiecl06Gg3a eMt89Re0jlv7AcdPIBs+wCEhfJHrrdEtoov51bdKUzV979A= X-Google-Smtp-Source: ABdhPJzF51Ay9gbXLuFxowLNDSGnnHvEuZeDGNzaq6RGe2GRWJ9mowPU7g882wXgn88k5Sc3nO+hHot6pPxYeJUR1Ew= X-Received: by 2002:a25:c646:: with SMTP id k67mr56417759ybf.110.1593739265727; Thu, 02 Jul 2020 18:21:05 -0700 (PDT) MIME-Version: 1.0 References: <202007022104.062L49Oo089298@repo.freebsd.org> In-Reply-To: <202007022104.062L49Oo089298@repo.freebsd.org> From: Li-Wen Hsu Date: Fri, 3 Jul 2020 09:20:54 +0800 Message-ID: Subject: Re: svn commit: r362900 - in head/sys: net netinet netinet6 netpfil/ipfw netpfil/ipfw/nat64 To: "Alexander V. Chernikov" , Neel Chauhan Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49ycc26vZqz4VlM X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 01:21:07 -0000 On Fri, Jul 3, 2020 at 5:04 AM Alexander V. Chernikov wrote: > > Author: melifaro > Date: Thu Jul 2 21:04:08 2020 > New Revision: 362900 > URL: https://svnweb.freebsd.org/changeset/base/362900 > > Log: > Complete conversions from fib<4|6>_lookup_nh_ to fib<4|6>_lookup(). > > fib[46]_lookup_nh_ represents pre-epoch generation of fib api, providing less guarantees > over pointer validness and requiring on-stack data copying. > > With no callers remaining, remove fib[46]_lookup_nh_ functions. > > Submitted by: Neel Chauhan > Differential Revision: https://reviews.freebsd.org/D25445 > > Modified: > head/sys/net/if_stf.c > head/sys/netinet/if_ether.c > head/sys/netinet/in_fib.c > head/sys/netinet/in_fib.h > head/sys/netinet/in_mcast.c > head/sys/netinet/ip_options.c > head/sys/netinet6/icmp6.c > head/sys/netinet6/in6.c > head/sys/netinet6/in6_fib.c > head/sys/netinet6/in6_fib.h > head/sys/netinet6/in6_mcast.c > head/sys/netinet6/in6_src.c > head/sys/netpfil/ipfw/ip_fw2.c > head/sys/netpfil/ipfw/ip_fw_table_algo.c > head/sys/netpfil/ipfw/nat64/nat64_translate.c Hi, sys.netinet6.redirect.valid_redirect is failing after this change: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15739/testReport/junit/sys.netinet6/redirect/valid_redirect/ https://ci.freebsd.org/job/FreeBSD-head-i386-test/9849/testReport/junit/sys.netinet6/redirect/valid_redirect/ Can you help check if the code or test needs fixing? Thanks, Li-Wen