Date: Fri, 3 Jul 2020 09:20:54 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org>, Neel Chauhan <neel@neelc.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362900 - in head/sys: net netinet netinet6 netpfil/ipfw netpfil/ipfw/nat64 Message-ID: <CAKBkRUy1PWfm9JK6B7Tyc-RQA58CEWQg6OD90n3_xSBSdKdU7w@mail.gmail.com> In-Reply-To: <202007022104.062L49Oo089298@repo.freebsd.org> References: <202007022104.062L49Oo089298@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 3, 2020 at 5:04 AM Alexander V. Chernikov <melifaro@freebsd.org> wrote: > > Author: melifaro > Date: Thu Jul 2 21:04:08 2020 > New Revision: 362900 > URL: https://svnweb.freebsd.org/changeset/base/362900 > > Log: > Complete conversions from fib<4|6>_lookup_nh_<basic|ext> to fib<4|6>_lookup(). > > fib[46]_lookup_nh_ represents pre-epoch generation of fib api, providing less guarantees > over pointer validness and requiring on-stack data copying. > > With no callers remaining, remove fib[46]_lookup_nh_ functions. > > Submitted by: Neel Chauhan <neel AT neelc DOT org> > Differential Revision: https://reviews.freebsd.org/D25445 > > Modified: > head/sys/net/if_stf.c > head/sys/netinet/if_ether.c > head/sys/netinet/in_fib.c > head/sys/netinet/in_fib.h > head/sys/netinet/in_mcast.c > head/sys/netinet/ip_options.c > head/sys/netinet6/icmp6.c > head/sys/netinet6/in6.c > head/sys/netinet6/in6_fib.c > head/sys/netinet6/in6_fib.h > head/sys/netinet6/in6_mcast.c > head/sys/netinet6/in6_src.c > head/sys/netpfil/ipfw/ip_fw2.c > head/sys/netpfil/ipfw/ip_fw_table_algo.c > head/sys/netpfil/ipfw/nat64/nat64_translate.c Hi, sys.netinet6.redirect.valid_redirect is failing after this change: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15739/testReport/junit/sys.netinet6/redirect/valid_redirect/ https://ci.freebsd.org/job/FreeBSD-head-i386-test/9849/testReport/junit/sys.netinet6/redirect/valid_redirect/ Can you help check if the code or test needs fixing? Thanks, Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUy1PWfm9JK6B7Tyc-RQA58CEWQg6OD90n3_xSBSdKdU7w>