From owner-freebsd-bugs@FreeBSD.ORG  Sat Jan 10 16:40:03 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5334F106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 10 Jan 2009 16:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 406458FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 10 Jan 2009 16:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0AGe2pd086307
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 10 Jan 2009 16:40:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0AGe2nU086306;
	Sat, 10 Jan 2009 16:40:02 GMT (envelope-from gnats)
Date: Sat, 10 Jan 2009 16:40:02 GMT
Message-Id: <200901101640.n0AGe2nU086306@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Andriy Gapon <avg@icyb.net.ua>
Cc: 
Subject: Re: kern/100513: [smbus] Inconsistent definition of SMBus addresses
 in SMBus drivers
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Andriy Gapon <avg@icyb.net.ua>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jan 2009 16:40:03 -0000

The following reply was made to PR kern/100513; it has been noted by GNATS.

From: Andriy Gapon <avg@icyb.net.ua>
To: bug-followup@FreeBSD.org, arthur.hartwig@nokia.com
Cc:  
Subject: Re: kern/100513: [smbus] Inconsistent definition of SMBus addresses
 in SMBus drivers
Date: Sat, 10 Jan 2009 18:34:49 +0200

 I've encountered the same problem while migrating some code from a
 platform using intpm to a platform with ichsmb.
 I looked through the code and it seems that ichsmb is the only driver
 that explicitly shifts slave address. All others seem to pass slave
 address as-is to the hardware. But there might be some subtleties - some
 hardware might expect the address to be in "unshifted" form.
 
 Arthur, if you are still interested and can verify this, are you sure
 that amdpm driver expects address to be in "unshifted" form (0x55 in
 your example)?
 I'd rather expect ichsmb to be the only "black sheep".
 
 -- 
 Andriy Gapon