Date: Wed, 21 Dec 2011 15:49:07 -0500 From: Eitan Adler <eadler@freebsd.org> To: Doug Barton <dougb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv Message-ID: <CAF6rxgkBWXgJ0HKXB=WMUDC09S9u3m_9fnkNkM6O1GNGR7Yhuw@mail.gmail.com> In-Reply-To: <4EF244CA.8040108@FreeBSD.org> References: <201112212027.pBLKRfPK084637@svn.freebsd.org> <4EF243F2.7030000@FreeBSD.org> <CAF6rxgku88PABx9J8UxfLkKm%2BY-3b6%2BDB%2BX6cjUce-LfX7VESg@mail.gmail.com> <4EF244CA.8040108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 21, 2011 at 3:42 PM, Doug Barton <dougb@freebsd.org> wrote: > On 12/21/2011 12:40 PM, Eitan Adler wrote: >> On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton <dougb@freebsd.org> wrote: >>> A better way to write this commit log would be, "Remove null pointer >>> checks that are extraneous because ..." =C2=A02/3 why, 1/3 what. >> >> Noted. > > Thanks. However, I was perhaps too subtle in asking you to actually > explain why they were not needed. =C2=A0:) - free never requires a null check - zwork is dereferenced in the line before the null check --=20 Eitan Adler Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkBWXgJ0HKXB=WMUDC09S9u3m_9fnkNkM6O1GNGR7Yhuw>