From owner-svn-src-head@FreeBSD.ORG Thu Dec 22 19:19:43 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC8E01065670; Thu, 22 Dec 2011 19:19:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 20CA28FC17; Thu, 22 Dec 2011 19:19:42 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so12071209vcb.13 for ; Thu, 22 Dec 2011 11:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=+18d4ECnwF34E/5SwacvUHXvI1F+Tply1+hh7M1x0vk=; b=ElInfm3oJx+HqeQGym3l+nUaB+9GOPtItNf8pzxA0buGa7kq+qU+eD13FAefmrcRDj DqWofITdgtrMZBfTsGM1Op77PTuAvc6sYMOE/z5skW4pq5mJPvK3qtmaWmtA5qzRp6aT MqXZr5uizhcVDZRP3qfJXmigLtcd+VtsUER0c= MIME-Version: 1.0 Received: by 10.52.24.11 with SMTP id q11mr6424152vdf.83.1324581582395; Thu, 22 Dec 2011 11:19:42 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Thu, 22 Dec 2011 11:19:42 -0800 (PST) In-Reply-To: <20111222180852.GA6965@freebsd.org> References: <201112211716.pBLHGhDH078507@svn.freebsd.org> <201112211700.42772.jhb@freebsd.org> <20111221232754.GA51331@freebsd.org> <201112220802.27434.jhb@freebsd.org> <20111222180852.GA6965@freebsd.org> Date: Thu, 22 Dec 2011 11:19:42 -0800 X-Google-Sender-Auth: DutceoOatymlI55UJoGOqRuea7E Message-ID: From: Adrian Chadd To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric , John Baldwin Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 19:19:43 -0000 On 22 December 2011 10:08, Alexander Best wrote: >> You don't think changes should be reviewed (that's what I said above, I = did >> not necessarily say it should be reverted)? =A0That's way out in left fi= eld if >> that is what you really think. > > no of course not. let's handle it this way: > > keep the commits and adrian@ and everybody else can test dim@'s > changes. if the commits broke anything, they should be reverted. Well, he's already reverted them. I've reviewed the HAL_TRUE -> HAL_OK change, that's fine. Nothing uses that particular bit of code in the HAL at the moment (and if someone wants to support the payload compression code for the AR5212 era devices, please let me know :) I'll test out the shift register changes tonight and see if I can dig up the AR5210/AR5211 datasheets internally. Once I've verified it's right, I'll commit the change. > the next time dim@ is about to touch non trivial code or code that is bei= ng > maintained by a certain developer, he should post his patches to some > mailinglist (-wireless@ in this case) and cc that particular developer > (adrian@ in this case). Yup. You guys already did that in November, so thankyou for that. I just hadn't until recently found equipment to test it out. > no hard feelings. ;) Oh there's no hard feelings. None whatsoever. :-) There, resolved! Time for a cool, refreshing glass of orange juice. Adrian