Date: Tue, 20 Jan 1998 10:00:19 +0100 (MET) From: Søren Schmidt <sos@FreeBSD.ORG> To: joelh@gnu.org Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: syscons.c Mode X handling Message-ID: <199801200900.KAA26591@sos.freebsd.dk> In-Reply-To: <199801200545.XAA00312@detlev.UUCP> from Joel Ray Holveck at "Jan 19, 98 11:45:25 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
In reply to Joel Ray Holveck who wrote:
> I'll be the first to admit that I don't know a thing about VGA
> programming, but, unless I'm wrong, there is definately something awry
> in this bit of code, from syscons.c:set_mode, in case M_VGA_MODEX,
> line 4055. This could be perfectly harmless, but
> special_modetable[10+0x11] gets set twice before anything is done with
> it. (special_modetable is a normal char array on the stack.)
>
> Anybody know what's going on here? This isn't anything that's
> important to my work, I just came across it while going over the
> mode-switching code, and it looks funny.
>
> /* set 240 lines */
> special_modetable[10+0x11] = 0x2c;
> special_modetable[10+0x06] = 0x0d;
> special_modetable[10+0x07] = 0x3e;
> special_modetable[10+0x10] = 0xea;
> special_modetable[10+0x11] = 0xac;
He he, its an artifact of the way the crtc noramlly is programmed, which
doesn't apply here. The last line can be safely ommitted...
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team
Even more code to hack -- will it ever end
..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801200900.KAA26591>