From owner-svn-src-all@FreeBSD.ORG Tue Mar 2 19:28:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B995106566C; Tue, 2 Mar 2010 19:28:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id ED7AE8FC19; Tue, 2 Mar 2010 19:28:49 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o22JSjjX021029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Mar 2010 21:28:45 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o22JSjmI037218; Tue, 2 Mar 2010 21:28:45 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o22JSjkP037217; Tue, 2 Mar 2010 21:28:45 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 2 Mar 2010 21:28:45 +0200 From: Kostik Belousov To: Luigi Rizzo Message-ID: <20100302192845.GD2489@deviant.kiev.zoral.com.ua> References: <201003021740.o22HemPA096942@svn.freebsd.org> <20100302185130.GC2489@deviant.kiev.zoral.com.ua> <20100302190344.GA5490@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lBPdJKrYqo3eKYSb" Content-Disposition: inline In-Reply-To: <20100302190344.GA5490@onelab2.iet.unipi.it> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204591 - in head: sbin/ipfw sys/conf sys/net sys/netinet sys/netinet/ipfw sys/netinet/ipfw/test X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2010 19:28:50 -0000 --lBPdJKrYqo3eKYSb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2010 at 08:03:44PM +0100, Luigi Rizzo wrote: > On Tue, Mar 02, 2010 at 08:51:30PM +0200, Kostik Belousov wrote: > ... > > > --- head/sbin/ipfw/Makefile Tue Mar 2 17:34:11 2010 (r204590) > > > +++ head/sbin/ipfw/Makefile Tue Mar 2 17:40:48 2010 (r204591) > > > @@ -3,7 +3,6 @@ > > > PROG=3D ipfw > > > SRCS=3D ipfw2.c dummynet.c ipv6.c main.c nat.c altq.c > > > WARNS?=3D 2 > > > -DPADD=3D ${LIBUTIL} > > > LDADD=3D -lutil > > > MAN=3D ipfw.8 > > Removal of DPADD is most likely regression ? >=20 > possibly. > i couldn't figure out why it was there in the > first place, can you clarify what it was for ? To depend on the libutil, so that ipfw is reloaded when libutil.a is changed. The question I do not know answer for, is why do we need LDADD. --lBPdJKrYqo3eKYSb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkuNZu0ACgkQC3+MBN1Mb4iwVwCgmQVXIqVCCkjI8ETIDAjIZ6os wXAAn3WU9A5T/0F4LJ2pK0jZkFSPk9xn =qBep -----END PGP SIGNATURE----- --lBPdJKrYqo3eKYSb--