Date: Mon, 17 Jul 2017 12:27:04 -0600 From: Warner Losh <imp@bsdimp.com> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r321080 - head/usr.bin/getconf Message-ID: <CANCZdfoc=yYPNqj9h27r0rZg08FKr6oQOeXE3kyyiMt0w9r2tA@mail.gmail.com> In-Reply-To: <201707171812.v6HIC9Cq082059@repo.freebsd.org> References: <201707171812.v6HIC9Cq082059@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 17, 2017 at 12:12 PM, Ngie Cooper <ngie@freebsd.org> wrote: > Author: ngie > Date: Mon Jul 17 18:12:08 2017 > New Revision: 321080 > URL: https://svnweb.freebsd.org/changeset/base/321080 > > Log: > Expose the ILP32/LP64 programming environments based on > __ILP32__/__LP64__ instead of by architecture. > > The list was incomplete (previous commits purged invalid architectures, > like __alpha__, but failed to add new ones). It's best to base the symbol > presence on whether or not the architecture is ILP32 / LP64 capable, per > the compiler. > > This fixes the ILP32/LP64 program environments on some architectures like > arm64, and by proxy fixes the tests on those architectures. > > MFC after: 1 month > Reviewed by: no one (timed out on feedback from imp) > You timed out because you never answered my question about other platforms. Warner > Differential Revision: D10787 > > Modified: > head/usr.bin/getconf/progenv.gperf > > Modified: head/usr.bin/getconf/progenv.gperf > ============================================================ > ================== > --- head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:07:53 2017 > (r321079) > +++ head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:12:08 2017 > (r321080) > @@ -30,11 +30,11 @@ static const struct map *in_word_set(const char *str); > * be updated. (We cheat here and define the supported environments > * statically.) > */ > -#if defined(__sparc64__) || defined(__amd64__) > +#ifdef __LP64__ > #define have_LP64_OFF64 NULL > #endif > > -#if defined(__i386__) || defined(__powerpc__) > +#ifdef __ILP32__ > #define have_ILP32_OFFBIG NULL > #endif > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoc=yYPNqj9h27r0rZg08FKr6oQOeXE3kyyiMt0w9r2tA>