From owner-freebsd-hackers@FreeBSD.ORG  Tue Sep 16 19:02:18 2014
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 920C86E0;
 Tue, 16 Sep 2014 19:02:18 +0000 (UTC)
Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35])
 by mx1.freebsd.org (Postfix) with ESMTP id 5368DCF1;
 Tue, 16 Sep 2014 19:02:18 +0000 (UTC)
Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534)
 id 1B58220E7088D; Tue, 16 Sep 2014 19:02:16 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
 smtp1.multiplay.co.uk
X-Spam-Level: **
X-Spam-Status: No, score=2.2 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX,
 FSL_HELO_NON_FQDN_1,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no version=3.3.1
Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170])
 by smtp1.multiplay.co.uk (Postfix) with ESMTPS id A2C9B20E70886;
 Tue, 16 Sep 2014 19:02:14 +0000 (UTC)
Message-ID: <4B404F031430407C98A6A553A5FF1843@multiplay.co.uk>
From: "Steven Hartland" <killing@multiplay.co.uk>
To: "Mark Johnston" <markj@FreeBSD.org>
References: <AEC968EBE6DE4E56A76DD7578DC25483@multiplay.co.uk>
 <CAJjvXiF4kPFW--SioqAvR+F1kwMgYUkfGqtLd4ZHh0jWhrNN5Q@mail.gmail.com>
 <20140916031318.GB26720@charmander.picturesperfect.net>
 <C5055A802D714A6F9BA38405ABC1B2D8@multiplay.co.uk>
 <20140916163927.GA36108@charmander.picturesperfect.net>
Subject: Re: ZFS SET_ERROR dtrace probe possible under FreeBSD?
Date: Tue, 16 Sep 2014 20:02:11 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
 reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Cc: hackers@freebsd.org, freebsd-dtrace@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2014 19:02:18 -0000

----- Original Message ----- 
From: "Mark Johnston" <markj@FreeBSD.org>

> You'll need to #include <sys/sdt.h> in kern_dtrace.c.
> 
>> 
>> Also is kern_dtrace.c the correct place for the probe define given
>> its zfs specific?
> 
> I was just thinking that it might be useful elsewhere too.
> 
> For now, perhaps the best place is in a new file under
> sys/cddl/compat/opensolaris/kern. Then it'll be part of opensolaris.ko
> and SET_ERROR will work for any illumos code in the tree, not just ZFS.

Thanks again.

I've created a review for this change below if you would be so kind:
https://reviews.freebsd.org/D790

    Regards
    Steve