Date: Fri, 02 Jun 2023 06:46:11 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270398] Fix the 'stripped' check from 'make check-plist' to report all unstripped files Message-ID: <bug-270398-7788-KEitIta8l3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270398-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-270398-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270398 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D67ce8cec004c85caeee5a6e965bd10f= 872e1b895 commit 67ce8cec004c85caeee5a6e965bd10f872e1b895 Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2023-06-02 06:40:46 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2023-06-02 06:45:29 +0000 Mk/Scripts: Fix the 'stripped' check from 'make check-plist' to report = all unstripped files Prior to this patch, the 'stripped' check always skipped the first unstripped file. It uses the "find [...] -exec sh -c 'readelf -S -- /dev/null $0 "$@" ||= :' -- {} +" command. When arguments are passed to shell like this: "sh -c 'script' arg1 arg2 arg3" - $@ within the script is assigned to 'arg2 arg3', and $0 is assigned to arg1. This is a quirk in how shells handle arguments in case when the script is passed using -c. This patch adds $0 to account for the first passed file. PR: 270398 Approved by: portmgr-lurkers (garga) Mk/Scripts/qa.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270398-7788-KEitIta8l3>