From owner-svn-src-head@freebsd.org Fri Feb 28 05:54:42 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6D4FC25ABA6 for ; Fri, 28 Feb 2020 05:54:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TJdr6Hggz4W6c for ; Fri, 28 Feb 2020 05:54:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf31.google.com with SMTP id by15so813860qvb.11 for ; Thu, 27 Feb 2020 21:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PL1jwe2bOJ9yWk9NLjkjxt8LuSrX3ODR6EijMNrESZA=; b=GsX7lwAEDt/DQ+kTqbRG6rWH0XNKLCVEiDzjUDU31+2aUZyVTiExyJcRhZ8G7OM080 PEbsNYaCoIk2rLico1MemHvKCorZR471Tf/VNhSu98mDME9+VfgbrUs/T+MMpi/L06Zb XKMFjvD69Mk9dDDLgiImMstHm0VpzB4RypLv8vKWhw0Q3iM3ICSOp9mNKIVvJaTmcINz EAU9g7MFVUq0sRLfdkE/fxh7HHJD6jmZNJNd/aXSdUM8KneUO/KuwAogT1W5WCI42rmQ NNZHuD2awMdi3yCkl3jPpXgpYzt7EkK06rfLRQHrAA43j71ZbMhbwtOcjHUSKRdVu0sy 81XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PL1jwe2bOJ9yWk9NLjkjxt8LuSrX3ODR6EijMNrESZA=; b=KWL8Mwmj8PpepuEz0Qa+QIZRZLzB7UJKlbcFWi9oQoAwGHeKLeC5R1RQBhl5D5M/W/ mUQncKCOt2opz+io+iYG9dwqLqzH6YQHWlHJfnZ3rEA9+mNKGO1u898dFgDfVSw7bDWf /qi9wahpZbuPAIrtn6n6ozM7sN80/cAmklf9S3lWqz7cfvdDNZNaoWXGiaa09IV0xovh PbX143glAk9pJhD6WAJtbT0nD9rxbyBZErmiSD5fGARQiIkpFUXViyFMmepa8hN5p6vK BlGhXrxV3pzsUPW4btxgkgrxLuY5cg94pJJDPYvJtvKbc16UF5qz+honaIjqQyVVOdnE pMbg== X-Gm-Message-State: APjAAAXRn/7NuCF6jumDF2v/qfn0z3vT03FFT4mFiijp8FHZoTVfivEO u8CD/x6q7oetQ9kzLkizWeWiScTUXYb+gNvj5/W4uA== X-Google-Smtp-Source: APXvYqztBQo292/U73H4p8PL+sGCeitM6u6c9Wv05yUUcJAKKraJKrXxiik4FHGvh01Tazvm5GwA0rpXq7jKUu15+BE= X-Received: by 2002:a05:6214:965:: with SMTP id do5mr2432436qvb.202.1582869273652; Thu, 27 Feb 2020 21:54:33 -0800 (PST) MIME-Version: 1.0 References: <202002271530.01RFUDJA087174@repo.freebsd.org> <5a876bf9-56b5-9465-07f4-2c540313755d@FreeBSD.org> In-Reply-To: <5a876bf9-56b5-9465-07f4-2c540313755d@FreeBSD.org> From: Warner Losh Date: Thu, 27 Feb 2020 22:54:21 -0700 Message-ID: Subject: Re: svn commit: r358392 - head/share/man/man9 To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 48TJdr6Hggz4W6c X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=GsX7lwAE; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f31) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.92 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.92)[ip: (-6.03), ipnet: 2607:f8b0::/32(-1.88), asn: 15169(-1.67), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 05:54:42 -0000 On Thu, Feb 27, 2020, 9:55 AM John Baldwin wrote: > On 2/27/20 7:30 AM, Warner Losh wrote: > > Author: imp > > Date: Thu Feb 27 15:30:13 2020 > > New Revision: 358392 > > URL: https://svnweb.freebsd.org/changeset/base/358392 > > > > Log: > > _Static_assert is to be preferred to CTASSERT. > > > > Document the existing prefernce that _Static_assert be used in > preference to the > > old CTASSERT we used to use for compile time assertions. > > Actually, I think what we want to use is static_assert(). The intention in > userland C is that _Static_assert() is an internal keyword and > adds static_assert() as an alias, similar to defining alignas, > etc. I think what we should do for the kernel is have define > map static_assert to _Static_assert and replace existing _Static_assert > usage with the proper spelling. > I originally did just that when people pointed out that there were hundreds of instances in the tree of _Static_assert and less than 10 of static_assert. We could do a sweep and change, but I wanted to document it. Even more so because I was originally mistaken. Warner John Baldwin >