From owner-cvs-src@FreeBSD.ORG Fri Sep 24 12:51:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2587216A4CE; Fri, 24 Sep 2004 12:51:57 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.190]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EFE643D48; Fri, 24 Sep 2004 12:51:56 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CApYJ-0002RC-00; Fri, 24 Sep 2004 14:51:55 +0200 Received: from [84.128.131.163] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CApYJ-0007ze-00; Fri, 24 Sep 2004 14:51:55 +0200 From: Max Laier To: Maxim Konovalov Date: Fri, 24 Sep 2004 14:50:48 +0200 User-Agent: KMail/1.7 References: <200409241218.i8OCIfQw021308@repoman.freebsd.org> In-Reply-To: <200409241218.i8OCIfQw021308@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7117761.npk7gPHhZB"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200409241450.59730.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: andre@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2004 12:51:57 -0000 --nextPart7117761.npk7gPHhZB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 24 September 2004 14:18, Maxim Konovalov wrote: > maxim 2004-09-24 12:18:41 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_input.c > Log: > o Turn net.inet.ip.check_interface sysctl off by default. > > When net.inet.ip.check_interface was MFCed to RELENG_4 3+ years ago in > rev. 1.130.2.17 ip_input.c it was 1 by default but shortly changed to > 0 (accidently?) in rev. 1.130.2.20 in RELENG_4 only. Among with the > fact this knob is not documented it breaks POLA especially in bridge > environment. > > OK'ed by: andre > Reviewed by: -current Can we have a plan to move towards turning it on again? For RELENG_6 the=20 latest. This check is useful and we should have the code exposed by default= =20 so that new code does not break the assumption. The documentation issue has= =20 to be resolved, of course. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart7117761.npk7gPHhZB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBVBgzXyyEoT62BG0RAgBYAJ9e7TCQO7h0IHrpgzmFI1ZXlYxnpwCff4MU QvytTuxrFDaUIHeCZHN7mwc= =H5JT -----END PGP SIGNATURE----- --nextPart7117761.npk7gPHhZB--