From owner-svn-src-head@freebsd.org Wed Mar 14 22:50:30 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC0B8F4F86E for ; Wed, 14 Mar 2018 22:50:29 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 653BB7AED1 for ; Wed, 14 Mar 2018 22:50:29 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm0-x22d.google.com with SMTP id h76so7058602wme.4 for ; Wed, 14 Mar 2018 15:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FJ0KObVfYEJuc6+g7DzWChT5CV4sxhgpEmS2qITuFZ8=; b=m8kr9lBTgh/bcWX2aVIoTdizqo9EDVNhrLIf0GyPuHLwCnAv1FAJXFxDzpiXzk2xzg KZqL0N4RUjiTYnMtTrDMDEcJWjnD1IMbq2A37K5ESrJxp1AwXbYk662HlQ3TBtC7GIV6 JznYjazuRNIp/jf+m/iR35QOnJYGIm54U+8+M45BmWXcTod6Ge1lmIZmoMGSNiBGLZ2M 7VA61u+EV+2Ig/vDuotSSXc2glhj7SFO7i9SKL4h75KdM7h2TVgyb3tIiaMs+vxmd26V nvLbAHd7Hibwil0cwi34EW0KUYOwkxWXLKt27/vhyYN1hdKVSRN+a8NnHA2dEpgV/oyI FTLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FJ0KObVfYEJuc6+g7DzWChT5CV4sxhgpEmS2qITuFZ8=; b=R8VidZ9ZcfPN08c1JTWjbobtTU51vOrvpq7ddYuY6UxhASo/8+LzQICdbwjqTUyvqJ Iy2qc2qpJI2rKDBE2tlfpB9atbMVdrQ22PhI8CAbdYibcGkz4PU0I918LotdGGscRdnC iRL107FwY0XqQ4YL3wkxev25gwyZyOsvkPcIOJMBhwF4a4Hc83hy7jQtirJzuPvXHODX vSWEVLiqYfRZqTDySosNNzqH+8yVyNVBT8YtbulJL21bklblUfsa8ohf43ApiGEu05ZG Smr7a1aH+c2y2raTsfnkcvlNSrhg9Ul0lAKWRo4D48+8rwlmCmDXXP+Y3EHE6zeSQmTX 6zxg== X-Gm-Message-State: AElRT7Hk+TNwrJ2b+dxIsVS7VxJ5mB7jVe/whp6UlYEA44V6TC7u1cvN SH6aZoYUnL+FryYGWmPVk6a3kg== X-Google-Smtp-Source: AG47ELu+bty+4sg7dgU/SNvtcsTUNvLikp1UMCWjRusIKZ7v48e8u+x6EKFiJdNVsJ5HC7lxOF0fmQ== X-Received: by 10.28.108.7 with SMTP id h7mr2825729wmc.35.1521067823304; Wed, 14 Mar 2018 15:50:23 -0700 (PDT) Received: from mutt-hbsd ([5.254.112.154]) by smtp.gmail.com with ESMTPSA id m9sm4205930wrg.79.2018.03.14.15.50.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 15:50:22 -0700 (PDT) Date: Wed, 14 Mar 2018 18:50:09 -0400 From: Shawn Webb To: Alan Somers Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <20180314225009.gu3awgryggsxqmff@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6hriqc5dgbphwzer" Content-Disposition: inline In-Reply-To: <201802251429.w1PEThjY035303@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20171215 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 22:50:30 -0000 --6hriqc5dgbphwzer Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > Author: asomers > Date: Sun Feb 25 14:29:43 2018 > New Revision: 329984 > URL: https://svnweb.freebsd.org/changeset/base/329984 >=20 > Log: > Don't declare __assfail as static > =20 > It gets called by dmu_buf_init_user, which is inline but not static. S= o it > needs global linkage itself. > =20 > Reported by: GCC-6 > MFC after: 17 days > X-MFC-With: 329722 >=20 Hey Alan, This commit breaks compiling world with ASAN. Some applications, like zfs, will fail with this error: /lib/libuutil.so.2: Undefined symbol "__assfail" Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --6hriqc5dgbphwzer Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlqppx0ACgkQaoRlj1JF bu4UmQ//UXvruRxifAAXzUyTuhNu++/qKJv1GqV7joVYk71vYfNuSz/kWtXH6G1M f9KZA8+4eK2RlvaJi/UOEWgN1MjJK2HQMu1DxtqjeuTx4i2qTD1eRHGRRO6beEdk mIh6sru587E8yFCHGefYvRq097Fc9gtyIInkU3MbdiF8avfiqbRSy+KCxUcUeo6P bH3A57XONjN8Af+B3U+L+CR1pPiwh5oWKAcFNcOKDBp7v8YdsLZQNwUccfgUNVzk DlkW3bnGU62z/qfsI4yDtNp8tgpqy22AX3Ii1WMcy0lnMM/MrXRM1yrw9MDX93ew UTlzf3Z37TlIPHdMuj+FdmNQUk6RWZl6rNiwuOaZIR47pV/FgzboEXKdWui0av4d CFtfQtYkp+Lu9vAOwV7ahy8mDNVGfVp8MZsyPH5mFzw/SkQGvnMZA8n/ciNu+8ys 12HSBHlaBh9sCvJ0fHIbdfITmYkDgwqip00yyHaET4itWz5xcpuiQvKDWNMHisKZ NvRRuzzooqO50vN9/V1fQ7Zc8Jsa9mZTqJ4w2K8wg7m4PckJhVhVR7y27m9WWBol ZX1wmwXBHnYpS7WwRAHp+fx9ELGKrxMVn9rM7v+KwIuv2sr0DI7p85QfK7503HN5 oUwkJ9dI3CZJ2UK/fAmZvia4rbMWutpFwyM5Q17Mr7WQTkjvFeQ= =8pIF -----END PGP SIGNATURE----- --6hriqc5dgbphwzer--