From owner-freebsd-current@FreeBSD.ORG Fri Apr 9 06:59:29 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BAA616A4CE for ; Fri, 9 Apr 2004 06:59:29 -0700 (PDT) Received: from white.imgsrc.co.jp (ns.imgsrc.co.jp [210.226.20.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3D7943D4C for ; Fri, 9 Apr 2004 06:59:28 -0700 (PDT) (envelope-from kuriyama@imgsrc.co.jp) Received: from localhost (localhost [127.0.0.1]) by white.imgsrc.co.jp (Postfix) with ESMTP id 9A7DC284092 for ; Fri, 9 Apr 2004 22:59:27 +0900 (JST) Received: from black.imgsrc.co.jp (black.imgsrc.co.jp [IPv6:2001:218:422:2::130]) by white.imgsrc.co.jp (Postfix) with ESMTP id 2ADCA284091 for ; Fri, 9 Apr 2004 22:59:26 +0900 (JST) Received: from black.imgsrc.co.jp (black.imgsrc.co.jp [IPv6:2001:218:422:2::130]) by black.imgsrc.co.jp (Postfix) with ESMTP id EBCC41E462A for ; Fri, 9 Apr 2004 22:59:25 +0900 (JST) Date: Fri, 09 Apr 2004 22:59:25 +0900 Message-ID: <7m4qrtxneq.wl@black.imgsrc.co.jp> From: Jun Kuriyama To: Current User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by AMaViS snapshot-20020531 Subject: Clean up libdisk for WARNS=4 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2004 13:59:29 -0000 I did a bad commit for WARNS=4 of libdisk which breaks non-i386 build. I'm trying to solve this in other archs, too. http://www.imgsrc.co.jp/~kuriyama/BSD/libdisk-20040404.diff o Added many __unused's to avoid warnings on all archs. o Added file local struct definition in open_ia64_disk.c to avoid pointer alignment problem. o Renamed some variables to resolve conflicts with other enum constants (same as in i386). o Used uint64_t buffer instead of u_char buffer. This simplifed uint64_t array manipulation in latter of this function. But it looks ugly. o Used ssize_t storage instead of direct comparison of singed/unsigned. I'm not sure all of this is done by good way or not. So I'd like to be reviewed... -- Jun Kuriyama // IMG SRC, Inc. // FreeBSD Project