Date: Tue, 23 Oct 2001 10:42:20 -0700 From: Peter Wemm <peter@wemm.org> To: John Baldwin <jhb@FreeBSD.ORG> Cc: hackers@FreeBSD.ORG Subject: Re: getenv_foo and TUNABLE_FOO_FETCH change Message-ID: <20011023174220.BA0EB380A@overcee.netplex.com.au> In-Reply-To: <XFMail.011023102635.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> Also, one final note about using do { } while(0). If you actually read
> style(9), you will see that you are supposed to use it for compound statement
s,
> not just for any macro that happens to be more than one line long. If the
> macro's body is a single statement, it doesn't need the do { } while (0) bit.
It was there so that the macro didn't have a "value". Since you're
changing this so they all have a meaningful return (eg: TUNABLE_STR_FETCH()
did not before) then removing this makes sense.
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011023174220.BA0EB380A>