From nobody Wed Sep 14 13:42:10 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MSM2V4v2Yz4c8SK; Wed, 14 Sep 2022 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MSM2V4SLjz3vb6; Wed, 14 Sep 2022 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663162930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a90pTK4yy+DolByMxnpqbHP7SXzGW7vhH6xmZs5EidU=; b=Ou3W//mctcVhbYWhEmSD91qUPb6cFtq/rIMvcGhumvW6L+eDAvz9zebkPFfO9AZrpXbGDv r71Y7iQqD/g95LnGucAGxmMjSCQq6qUu+ZrPBtSsF0elPW0FzN9AQAJ9l9LGjvusOYLkzI WWrAhQ2YyYZwcxUXTZccA9TbEyK149AQ23ybi6Awdhb8zj/N0s9E4rCAC8nP7Ge0BkiKRg 7EaahlBADzlbmEIhmyEW9eaauZX+sd4a/zpBW0668ZSWEKZzcaXBOaVRgyOESoMUORIReo TESFLmUJspseK6W/0L7E8HxMfqj4bpOKxloK+YTQ9aKIeXNu04AoCppv+zCvNg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MSM2V3W0fzh8b; Wed, 14 Sep 2022 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28EDgAKB048729; Wed, 14 Sep 2022 13:42:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28EDgAkq048728; Wed, 14 Sep 2022 13:42:10 GMT (envelope-from git) Date: Wed, 14 Sep 2022 13:42:10 GMT Message-Id: <202209141342.28EDgAkq048728@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: e2386f18eca2 - main - nxprtc: Fix timing issue with register access. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e2386f18eca2f6f75f7c5c2d49d603e3d2674509 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663162930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a90pTK4yy+DolByMxnpqbHP7SXzGW7vhH6xmZs5EidU=; b=a3XjZgn+5woB5le9H7kRL8ogcOsQxpjQuQhAotP/5W8NhMOca/NPYx2EZE9DIR3DjzkTdb 13Rr5BI2VAVJlw+DwNmlqOIbcXR2idOg+WkBO3d4Jud2nwQWi4bZAXXTBorQ7z38084yAp NKiepfu3HeruF9GE8QlrGM9sAkDvCdpBqXW7y1OsUxDTeFCX2Uv7JVEdzqLZLueUqImsFR Lzv0WUEDMWZhVZuE+4d7hHCC1r0DOL4SDo9z8eB/BvUVW/s8pnt2Ln8142wrhc9NWlyWFM G/ZET/4gv7KPHwTu6UQYbJv6nCCFpm0AI96yzS7z4p4Q2tFcCzI+E/L/wBWLcA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663162930; a=rsa-sha256; cv=none; b=yn5bN+Nk5nAxb2HvKI7xTG0G0G7PAE2kW9cG0RkixZeERjBRaFNoHbt7F1LRDZjGjPrwRk fxZNuZ2mzQfq7yT8MBpgyV/+ZSFl3XBep6AkZSd1lQoLuATUFXbM01IpLh3jB6AAK7cWT+ V4qQYF2PWXB6YOd45CihRa4hUtZrYtVwC5ZGP3RXmg1GvCEh3BHgn6AAL9GhgJylUffWnz MG/m6sFdgCwJMVax0wrnqOooZaNSFXFIKRvmaTFtJSG7j5QgUbsM4EbfmDsx2fng61mOTr V6bate6x1rBiuPWL0fIXyIo6OtINFOp3lwukXAMF3m8UwE6MzdG22jMc4CqP4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e2386f18eca2f6f75f7c5c2d49d603e3d2674509 commit e2386f18eca2f6f75f7c5c2d49d603e3d2674509 Author: Tetsuya Uemura AuthorDate: 2022-09-14 13:34:15 +0000 Commit: Warner Losh CommitDate: 2022-09-14 13:34:15 +0000 nxprtc: Fix timing issue with register access. My Adafruit PCF8523 RTC on either RPi2B or RPi3B+ failed to work around 80 ~ 90 % of boot-ups, by printing the following log lines. nxprtc0: at addr 0xd0 on iicbus0 nxprtc0: cannot set up timer Warning: no time-of-day clock registered, system time will not be set accurately This is due to pcf8523_start_timer(sc) returned non-zero in nxprtc_start() due to a register read failure of PCF8523_R_TMR_A_FREQ or PCF8523_R_TMR_CLKOUT or a failure to program a new value. The pause_sbt("nxpbat") sleep was too short and caused the register access failures. PR: 266093 --- sys/dev/iicbus/nxprtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/iicbus/nxprtc.c b/sys/dev/iicbus/nxprtc.c index 74ff3acef914..784b71dfc966 100644 --- a/sys/dev/iicbus/nxprtc.c +++ b/sys/dev/iicbus/nxprtc.c @@ -418,7 +418,7 @@ pcf8523_battery_check(struct nxprtc_softc *sc) device_printf(sc->dev, "cannot write CS3 reg\n"); return (err); } - pause_sbt("nxpbat", mstosbt(10), 0, 0); + pause_sbt("nxpbat", mstosbt(100), 0, 0); if ((err = read_reg(sc, PCF8523_R_CS3, &cs3)) != 0) { device_printf(sc->dev, "cannot read CS3 reg\n"); return (err);