Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Sep 2022 15:33:27 GMT
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 15b73a2a14d1 - main - ip_reass: use correct comparison in ipreass_callout()
Message-ID:  <202209141533.28EFXR1c085028@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=15b73a2a14d12a57bcdad8e6a5945396c0fd1e51

commit 15b73a2a14d12a57bcdad8e6a5945396c0fd1e51
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2022-09-14 15:32:07 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2022-09-14 15:32:07 +0000

    ip_reass: use correct comparison in ipreass_callout()
    
    Reported-by:    syzbot+55415dc73f9b89b87fce@syzkaller.appspotmail.com
---
 sys/netinet/ip_reass.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c
index a10dff9c8acb..06cdbca2961c 100644
--- a/sys/netinet/ip_reass.c
+++ b/sys/netinet/ip_reass.c
@@ -599,11 +599,11 @@ ipreass_callout(void *arg)
 
 	CURVNET_SET(bucket->vnet);
 	fp = TAILQ_LAST(&bucket->head, ipqhead);
-	KASSERT(fp != NULL && fp->ipq_expire >= time_uptime,
+	KASSERT(fp != NULL && fp->ipq_expire <= time_uptime,
 	    ("%s: stray callout on bucket %p, %ju < %ju", __func__, bucket,
 	    fp ? (uintmax_t)fp->ipq_expire : 0, (uintmax_t)time_uptime));
 
-	while (fp != NULL && fp->ipq_expire >= time_uptime) {
+	while (fp != NULL && fp->ipq_expire <= time_uptime) {
 		ipq_timeout(bucket, fp);
 		fp = TAILQ_LAST(&bucket->head, ipqhead);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202209141533.28EFXR1c085028>