Date: Tue, 26 Feb 2019 23:08:01 +0200 From: Toomas Soome <tsoome@me.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Fatih Acar <fatih.acar@gandi.net>, Baptiste Daroussin <bapt@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, jack@gandi.net, fatih@gandi.net Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common Message-ID: <E6486096-DCAE-4D62-AD23-17D084FD483C@me.com> In-Reply-To: <201902262102.x1QL2rIo032528@slippy.cwsent.com> References: <201902262102.x1QL2rIo032528@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 26 Feb 2019, at 23:02, Cy Schubert <Cy.Schubert@cschubert.com> = wrote: >=20 > In message <a69cf582-abc7-aff9-41c7-ed2a9e13e388@gandi.net>, Fatih = Acar=20 > writes: >> This is a multi-part message in MIME format. >> --------------6A54CE5B28D823DCB8C41577 >> Content-Type: text/plain; charset=3Dutf-8 >> Content-Transfer-Encoding: 8bit >>=20 >> On 2/26/19 5:36 PM, Cy Schubert wrote: >>> On February 26, 2019 8:11:31 AM PST, Baptiste Daroussin = <bapt@FreeBSD.org>=20 >> wrote: >>>> On Tue, Feb 26, 2019 at 05:04:11PM +0100, Baptiste Daroussin wrote: >>>>> On Tue, Feb 26, 2019 at 07:48:27AM -0800, Cy Schubert wrote: >>>>>> On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin >>>> <bapt@FreeBSD.org> wrote: >>>>>>> Author: bapt >>>>>>> Date: Tue Feb 26 08:18:34 2019 >>>>>>> New Revision: 344569 >>>>>>> URL: https://svnweb.freebsd.org/changeset/base/344569 >>>>>>>=20 >>>>>>> Log: >>>>>>> Implement parallel mounting for ZFS filesystem >>>>>>>=20 >>>>>>> It was first implemented on Illumos and then ported to ZoL. >>>>>>> This patch is a port to FreeBSD of the ZoL version. >>>>>>> This patch also includes a fix for a race condition that was >>>> amended >>>>>>>=20 >>>>>>> With such patch Delphix has seen a huge decrease in latency of = the >>>>>>> mount phase >>>>>>> (https://github.com/openzfs/openzfs/commit/a3f0e2b569 for >>>> details). >>>>>>> With that current change Gandi has measured improvments that are >>>> on par >>>>>>> with >>>>>>> those reported by Delphix. >>>>>>>=20 >>>>>>> Zol commits incorporated: >>>>>>=20 >>>>> = https://github.com/zfsonlinux/zfs/commit/a10d50f999511d304f910852c7825c70 >> c9c9e303 >>>>>>=20 >>>>> = https://github.com/zfsonlinux/zfs/commit/e63ac16d25fbe991a356489c86d40775 >> 67dfea21 >>>>>>>=20 >>>>>>> Reviewed by: avg, sef >>>>>>> Approved by: avg, sef >>>>>>> Obtained from: ZoL >>>>>>> MFC after: 1 month >>>>>>> Relnotes: yes >>>>>>> Sponsored by: Gandi.net >>>>>>> Differential Revision: https://reviews.freebsd.org/D19098 >>>>>>>=20 >>>>>>> Modified: >>>>>>> head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c >>>>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h >>>>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c >>>>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_impl.h >>>>>>> head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c >>>>>>>=20 >>>>>>> Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c >>>>>>=20 >>>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =3D=3D=3D=3D=3D > [...] >>>>>>>=20 >>>>>>=20 >>>>>> This broke my systems, many filesystems fail to mount causing >>>> nullfs late mounts to fail. No details now until tonight. >>>>>>=20 >>>>>> Suggest we back this out until it is properly tested. >>>>>>=20 >>>>>=20 >>>>> What fails to mount? what message? can you provide Gandi folks = more >>>> informations >>>>> so they can fix? >>>>>=20 >>>>> I will revert if we cannot have a quick fix but let s give them a >>>> chance to fix >>>>> first. >>>>>=20 >>>> With the proper email in CC there is a better chance to reach at = them >>>> :) >>>>=20 >>>> Best regards, >>>> Bapt >>>=20 >>> Sorry about that. I'm terribly frustrated as this broke my mail = gateway, ha >> ving to fix it using juiceSSH on my phone on the bus. Ssh on the = phone makes=20 >> for a very grumpy Cy. >>>=20 >>> I did bring my personal laptop to work, so I'll try to help out = testing thi >> s at noon here and maybe look at it more. I'll help out any way I = can. >>>=20 >>>=20 >>=20 >> Sorry about all this... >> Could you try the attached patch, it should fix the issue. I don't >> understand how this regression happened, it's not present in ZoL... >> I'll check with Jack who worked on this when he's back from PTO. >>=20 >> Thanks. >>=20 >> --=20 >> Fatih ACAR >> Gandi >> fatih.acar@gandi.net >>=20 >> --------------6A54CE5B28D823DCB8C41577 >> Content-Type: text/x-patch; >> name=3D"mount.patch" >> Content-Transfer-Encoding: quoted-printable >> Content-Disposition: attachment; >> filename=3D"mount.patch" >>=20 >> Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c >> = =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D >> = =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D >> =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D= 3D=3D3D=3D3D >> --- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c = (revision 3=3D >> 44590) >> +++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c = (working co=3D >> py) >> @@ -1260,11 +1260,11 @@ >> if (*a =3D3D=3D3D '\0') >> return (-1); >> if (*b =3D3D=3D3D '\0') >> - return (-1); >> + return (1); >> if (*a =3D3D=3D3D '/') >> return (-1); >> if (*b =3D3D=3D3D '/') >> - return (-1); >> + return (1); >> return (*a < *b ? -1 : *a > *b); >> } >> =3D20 >>=20 >=20 > Thanks. This fixes this particular issue. >=20 > There is one other minor issues that should also be addressed. The = mount message > at boot previously displayed: >=20 > Mounting ZFS filesystems: = (44/159)^H^H^H^H^H^H^H^H(106/159)^H^H^H^H^H^H^H^H^H(15 > 9/159)^M >=20 > Now it displays: >=20 > (null): (44/159)^H^H^H^H^H^H^H^H(106/159)^H^H^H^H^H^H^H^H^H(159/159)^M >=20 >=20 see https://www.illumos.org/issues/10205 = <https://www.illumos.org/issues/10205>; for this one. rgds, toomas=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E6486096-DCAE-4D62-AD23-17D084FD483C>