From owner-svn-ports-head@freebsd.org  Tue Jan 23 15:12:59 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AA02ED8688;
 Tue, 23 Jan 2018 15:12:59 +0000 (UTC)
 (envelope-from tobik@FreeBSD.org)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 516A780436;
 Tue, 23 Jan 2018 15:12:59 +0000 (UTC)
 (envelope-from tobik@FreeBSD.org)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id AEC3020BC7;
 Tue, 23 Jan 2018 10:12:52 -0500 (EST)
Received: from web3 ([10.202.2.213])
 by compute4.internal (MEProxy); Tue, 23 Jan 2018 10:12:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=mwJ/Pl
 mqAafTSJdt+u9TajTQN1fUSebl3c1b4J2efWI=; b=U2L3WbJibct8XLdJmZoW9W
 V464wU1/SSOGWgRn6Xkj0vGE4cKRMf3kXObUgmeRywSAc0cltEu6VrXBpBP5ECSK
 HwMOOIMY0t13D6B0ls8/4TWdPdXQKzh6u03mXGW7TrPv6zLbY6DibIlrDtPNphy+
 K3tzIjKIySxa+R8Xq43a+hvdC25CBVLTZdvmajbaQP4q0vDhroLDfxESX0VyIlhQ
 8rcUiLZZLpans1gAleancaPyuuG/JV5HIxHsrd9KTnaIidRuGkBPzrx9g2ro7pKq
 LzGEBWKk6PI73cQpduzErdciOwr8QPpFaDpil5wonqaWyFanV+woINrcc7IykDgg
 ==
X-ME-Sender: <xms:9FBnWpDYuAKtNp5GtWU3JU8rWElME4QZ_bnJEMENDPj77lj5XNhq0Q>
Received: by mailuser.nyi.internal (Postfix, from userid 99)
 id 8BB029E3C7; Tue, 23 Jan 2018 10:12:52 -0500 (EST)
Message-Id: <1516720372.2689994.1245262664.06EEC8C7@webmail.messagingengine.com>
From: Tobias Kortkamp <tobik@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
X-Mailer: MessagingEngine.com Webmail Interface - ajax-315c6b3a
References: <201801231415.w0NEFuvx082953@repo.freebsd.org>
 <20180123141944.GB73049@FreeBSD.org>
Date: Tue, 23 Jan 2018 16:12:52 +0100
Subject: Re: svn commit: r459753 - in head/deskutils: . freeplane
 freeplane/files
In-Reply-To: <20180123141944.GB73049@FreeBSD.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2018 15:12:59 -0000

On Tue, Jan 23, 2018, at 15:19, Alexey Dokuchaev wrote:
> On Tue, Jan 23, 2018 at 02:15:56PM +0000, Tobias Kortkamp wrote:
> > New Revision: 459753
> > URL: https://svnweb.freebsd.org/changeset/ports/459753
> > 
> > Log:
> >   New port: deskutils/freeplane
> >   
> > Added: head/deskutils/freeplane/Makefile
> > ...
> > @@ -0,0 +1,35 @@
> > +# Created by: Lo??c Bartoletti <lbartoletti@tuxfamily.org>
> > +# $FreeBSD$
> 
> ASCII please.
> 
> > +# Install freeplane.sh with the right permission, link to it to bin/
> > +# and let it resolve the path to DATADIR automatically to avoid
> > +# patching it further.  For this to work it has to be a link to an
> > +# absolute path.
> > +	${INSTALL_SCRIPT} ${WRKSRC}/freeplane.sh ${STAGEDIR}${DATADIR}
> > +	${LN} -s ${DATADIR}/freeplane.sh ${STAGEDIR}${PREFIX}/bin/freeplane
> 
> Symlinks pointing to an absolute path are bad.
> 
> ./danfe

Can you please explain why they "are bad"?