From owner-freebsd-rc@FreeBSD.ORG Tue Nov 8 18:13:17 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A9DA16A41F; Tue, 8 Nov 2005 18:13:17 +0000 (GMT) (envelope-from maksim.yevmenkin@savvis.net) Received: from ismybrain.com (ismybrain.com [64.246.42.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC5C643D49; Tue, 8 Nov 2005 18:13:16 +0000 (GMT) (envelope-from maksim.yevmenkin@savvis.net) Received: from [10.254.186.111] (localhost.localdomain [127.0.0.1]) by ismybrain.com (8.11.6/8.11.6) with ESMTP id jA8IDAJ18234; Tue, 8 Nov 2005 13:13:14 -0500 Message-ID: <4370EAB4.8090000@savvis.net> Date: Tue, 08 Nov 2005 10:13:08 -0800 From: Maksim Yevmenkin User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <4357CEA5.1000308@savvis.net> <4357D9E2.6010701@ebs.gr> <4367E346.4080106@savvis.net> <20051102111709.GD2465@comp.chem.msu.su> <20051102161311.GA8499@odin.ac.hmc.edu> <43690365.60909@savvis.net> <20051102190655.GA3961@odin.ac.hmc.edu> <436A6649.7000602@savvis.net> <20051103203217.GA30685@odin.ac.hmc.edu> <436BE02D.2020404@savvis.net> <20051107200040.GB29473@odin.ac.hmc.edu> In-Reply-To: <20051107200040.GB29473@odin.ac.hmc.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org, Panagiotis Astithas Subject: Re: [RFC] rc.d integration for the bluetooth subsystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 18:13:17 -0000 Brooks, >>please find next revision of bluetooth-rc stuff at >> >>http://people.freebsd.org/~emax/bluetooth-rc-1.diff.txt >> >>in this revision i have moved all bluetooth configuration files under >>/etc/bluetooth. bluetooth.device.sample is now called 'default.conf' and >>file that contain device specific overrides called '$dev.conf' (i.e. >>'ubt0.conf'). >> >>so, '/etc/rc.d/bluetooth start $dev' does the following >> >>1) sets hardwired defaults (for backward compatibility) >> >>2) reads up /etc/bluetooth/default.conf (if any) > > I think /etc/defaults/bluetooth.device.conf might be better since we do > have a defined location of default files and this will discourge people > from messing with them. that is fine with me. i'm sorry this is taking so long :) now the last question: should we keep device specific files under /etc/bluetooth or just under /etc? right now i have devfs.rules, pccard.conf, periodic.conf and rc.conf under /etc/defaults. overrides for these go into /etc. another alternative (which probably no one is going to like) is to use /etc/bluetooth/defaults/device.conf (defaults) and /etc/bluetooth/$dev.conf files (overrides). >>3) reads up /etc/bluetooth/$dev.conf (if any) >> >>4) starts the stack >> >>even though /etc/bluetooth/{default,$dev}.conf are not exactly shell >>scripts they are still kinda like shell scripts :) these files should >>follow sh(1) syntax to set the variable, comments etc. >> >>the parser in bluetooth_read_conf() is very simple and value of a >>variable is still used in sh(1) eval. so one must be careful when >>editing these files. >> >>is this looks like something? i also could write >>bluetooth.device.conf(5) man page that describes the parameters as well >>as the syntax of the files. > > A bluetooth.device.conf(5) man page would be a good idea, though the > example file is quite good. agreed. thanks, max