From owner-cvs-all@FreeBSD.ORG  Wed Feb  8 08:49:41 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1EFCA16A420;
	Wed,  8 Feb 2006 08:49:41 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 825B143D6A;
	Wed,  8 Feb 2006 08:49:36 +0000 (GMT)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.13.3/8.13.3) with ESMTP id k188nYPS049122
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 8 Feb 2006 11:49:35 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.13.3/8.13.1/Submit) id k188nYMu049121;
	Wed, 8 Feb 2006 11:49:34 +0300 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Wed, 8 Feb 2006 11:49:34 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Qing Li <qingli@FreeBSD.org>
Message-ID: <20060208084934.GJ877@FreeBSD.org>
References: <200602071959.k17JxkXv002652@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200602071959.k17JxkXv002652@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2006 08:49:41 -0000

On Tue, Feb 07, 2006 at 07:59:46PM +0000, Qing Li wrote:
Q> qingli      2006-02-07 19:59:46 UTC
Q> 
Q>   FreeBSD src repository
Q> 
Q>   Modified files:
Q>     sys/netinet          tcp_syncache.c 
Q>   Log:
Q>   Fixes a crash due to the memory of the newly allocated syncache entry
Q>   in syncache_lookup() is not cleared and may lead to an arbitrary and
Q>   bogus rtentry pointer which later gets free'd.
Q>   
Q>   Reviewed by: andre
Q>   MFC after: 3 days

I think it will be better just pass M_ZERO flag to uma_zalloc(). Also,
do same in the second uma_zalloc() call in this file.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE