From nobody Thu Aug 17 08:14:03 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRHpn0G9Nz4qP6v for ; Thu, 17 Aug 2023 08:14:25 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01olkn2058.outbound.protection.outlook.com [40.92.53.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRHpl0VPsz4Fnj for ; Thu, 17 Aug 2023 08:14:23 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=Ah2D2w7E; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (mx1.freebsd.org: domain of tatsuki_makino@hotmail.com designates 40.92.53.58 as permitted sender) smtp.mailfrom=tatsuki_makino@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWioLGZ4xlLZGhxhHRmHhSedaMOQuH98uRxUgkmCMgOgeGrBdxr7ex+lGhD+x6Kl9hfgWC3h6EPHY32OIarNCIyh39AS27R4t2c8k1uL7if77XLoyJmc0BrqhA+kFJ7d8n3EDK2YZo9WSZZMya7UqVnrGuVIqs/eJa8JCzU/FKzrhov8mbVexsoq5RylX+Jhu/oe0yuJAZsJYndCEhHJNxXsqQtuTrDWeydEqgcHbXJDR3v7eLDjDKjOLNtWGu5qMkIfxLcdS/k0vIJlfq7kr7RIozwl6LNRZMUAhJmkZw5MFAyRl6Jq4Y0oUTDh2sYtEtbJcuE2gQNlXwEESOG6lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cUczlVsU8djBdNPe4BWvT8rwWeV3IZtCjLsNSWM2vpA=; b=SDmUSigOnK6uARTT6aY0YE+YZFQ5pPwBBdHYlxgMOFZazv4Up8p7tGszH8qWbQMCbed8JwNtbVOky5oUJK6D6cfhrAJDhAlxddqcaDnz+uBSIXfVF4DuUvWR28PKadfBlazIvMRt372CI36yNMednkh44vH6Ll+8k1JqLtPCr0liECT6WF5pU+OmjmU4l3xg9TiTvrEPeWjmgOS859q/t0ysVnGspJP1u/a0q1cfxCVm+8lznJB/mgBcDz5Zl4IOg0w55jOyZrF08CGbFekXwPmrr78H5Oxth8Svw44+ls/yiunf3FzPJ0tSNcc9ROIqPaBQsEzz8BxmFPfE8LmJOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUczlVsU8djBdNPe4BWvT8rwWeV3IZtCjLsNSWM2vpA=; b=Ah2D2w7EwT5Ubk+N2/285ULUzmzHNKp0Gd5krau4u/AvxYsO3Hb9trwPQo58YgEhDdrEpVLVvi5rzmXsrXvKylhPWEw/4Qt1w1YNGzjM0xhPgC3FK/6VzdlQd8C4SwSWp/ERHpaAxC+se9xdTaBYxAIXnaqMHoeGluw+jyXaSeXYGke+2ZDldfiuNU4YcpSYUuy0QisXCELfTDD4xl0OpyPox1RG2QOYtHwvgyxdMxS1pCTzwiEvMBRhpO+Q+pVArNii70+2Wr5sRph673pbEv3tQJIZ4MPsiOgk9QPMF8E8+q7T37nsSZBxxNDNRCCpfDpkU//lyQw1GeE0eyNCyg== Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) by JH0PR01MB5467.apcprd01.prod.exchangelabs.com (2603:1096:990:c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Thu, 17 Aug 2023 08:14:16 +0000 Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::6dd9:4ab1:e67e:c5b3]) by SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::6dd9:4ab1:e67e:c5b3%4]) with mapi id 15.20.6678.031; Thu, 17 Aug 2023 08:14:16 +0000 Subject: Re: plist-check not reporting orphaned files present in a @comment To: ports@freebsd.org References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> From: Tatsuki Makino Message-ID: Date: Thu, 17 Aug 2023 17:14:03 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [aucegYs8eb2MyTj3ROLJM55CgtUkco9C] X-ClientProxiedBy: SG2PR04CA0179.apcprd04.prod.outlook.com (2603:1096:4:14::17) To SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) X-Microsoft-Original-Message-ID: List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR01MB5036:EE_|JH0PR01MB5467:EE_ X-MS-Office365-Filtering-Correlation-Id: 009416c0-dbb6-427c-6837-08db9ef9f2fb X-MS-Exchange-SLBlob-MailProps: AZnQBsB9Xmp/lAUbXAattgUcCpsR7e1UD3fIWAxMmgwoSmnvKANPZdrQvj4pTIJR7OIgNHQEAqjuegULsP6/ZrKhn5Opq1tQnOFXqjpUfkjCqI3pilN9fDkchc+y6/j9dCKZGgiNuvt8dxtGXCCyc7mjOtrhZq5k2LX4lZxJmUWq+P0oyNXZD1SJE67aWmLIvgQ7yR+0o7krIJ4o20Kkf1EXEYymIER9CPXAGx36wCPx1ncH1n84vJ7ipyIVoPXWYlH8qU+yS5npgzRRSHTuNrh9uhLd1ej/GrjPIGbG5aCUj3OdvTe3ibACKvPxtku5fhpMtMVPTOlCkLHHuIAbHav3Atgib6Y+m0uXyYnoiJzhkTWj5xnen8tEsmPufC6HfD+/qJbD22/kvvBbgffXOj3Azq1qB9WrJW+Em+fpewI3deyZvvfokhUtix9m2RDV49krx9RVi3dZRYHvdXdX1qnTRYy99TEJChQVzemMAwH27aLYczLoWiGaiuVYmCQs0bKCkgbihYByy9ZEVIWQxNJYL53gfrRaUgea0fQHkWk8N/1wYNPbmRmYTSvqKeq0C84dSCnUamEuXV9LDiI42rTFqRvN70M9K5lCldASauNVXaTC4jRcgq8ChnKxUNy9D2vVHXsowNvT08AslYAf0cW6I0rnjsw7rhulOFlqd4Ln/7H8hDDfyoRNs72/LpOfh/Pyhsgy11pErn0y4rv0QlBBEz4K/2A2b6EP63Fq4R0JIvlt+2YigqXfSmLJkPhXkddCGWT9pFU= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 84di6mHvSuW/9xWkhqHLCio0TQusIffkvqwjCdm5IzcxPY1qgXOZJFofl9An3wThl6eQBHBsUQz8fRC5Vi2S7veMELx+R8HKlq4oRvuD//lCxyVhbj8n+VEqjMUfifdad2kfRnb+3Woj2sjCFiBu6TMtwYK+Jiao04QiWBS0hESyIrvRvH5RIjPcFstgNcBC8GUQAuEI9F1nFcVhUmQ/H5jOuiCkw07miBiBLijp3QKdMdjyn0H1n7PHspXS0n5QhSXHzPUEEDRGJ57GfUywoCJoOXQph+2f/8hdwQp9jORU5FdzPVaqSG54bV8yG2pY/D9GXzTL5CTCj/VX9jbFKCiCcbDrPNdwWZdbwRfE1XHHbMbFAELTOSpORkLjHiNRSHi+mSCrMTeEPIXvHSYoVITxCHK79Y+nx9J5qqoWskIQIT7GYn6Ui6JjkvA/BkPZM5vcQt/TKMF5fKrymKQqGV+nDz1tlnKhUpiPsNVoFy1KZ0InnYtO9HGod3Wauaek31YX2IDJbz5tgNqpxLaMNK4BkMjJ4PlRaY9g4e8qkzvlGuow/8Z1N3c57wRbFgVSt6cQfJc7IpMSVgTwUyn0sv6wCLAgayGdblMn8hONdk0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFNsMEF3T0llYlJuU2xoZ1RjYzRLVGhCaytkMnRqZDNoRFIrcCtiL3kzc2RY?= =?utf-8?B?aGhKMnJvbEhKWHpIRFZmc2dXVzhMNlhreU5wL0QxM3RzR0o1YmR2WmxkWmI1?= =?utf-8?B?cG94YmpjdjAzRmpDbjJ3eldaVDhodnFwdk9yVENQVElES0xUc3BPclVQZmhC?= =?utf-8?B?SXFyc3prRDVqT1ZiUWpXTVJzVkpQcDBTQUV2TzVQTU0zcVZQeGYrTUZHZmtC?= =?utf-8?B?a1VKVWFSQWU3QldYeTRuTnczL0ZKdjlLVWdJenQ3K01FQzl6SEQvbERPa1Rt?= =?utf-8?B?UFlQVmE0L0ZOQjNrMTU0YXBZYnkvbXY4amNYT0FzS3hFbnJsY3BBYUx2Umtm?= =?utf-8?B?aEtDeCswa3lRbHhWbmcrR0dYcGlBR2ZHYnAzeDgrVjR0NW5XTFMrU1VQelhr?= =?utf-8?B?a2RicXhSWUU0bUFtMzMxd1Z2UElFMHk4ZUIwNTZjN2U2NENxK3JwU2hKQlFy?= =?utf-8?B?NCsrRzZUR3h6M1IyczVPNGVhVC9BL3FWUlM0NnZHaUhpdmo4cWZrSVBQRlhL?= =?utf-8?B?OXZKNGtJbm1mNG0vMnJJZ3RHQlhySStPdUxCcXlzcmlaRy9yNU8yUW5qdWVD?= =?utf-8?B?NW9vL2pvRUF1dlJ6c25taHFYcnd1Vm1nQ1ppc2p5dEFxdCtMZlNJZTNOdm1E?= =?utf-8?B?OTU5cG9GbVdOaGJ6WlRiaWY4YjhYbHpwN0M1NUcxK0swb21pMVNZRllsMHRC?= =?utf-8?B?L05uMDBuUkZZcDVRU0hqUGZsbDkvUDBTM1VadkpRcHFtaXgzdkFqTmpBTUl1?= =?utf-8?B?VjB0VzZrUEVWT2pqcnNTQ2pDamhUWmN4VngwR24rU2ZzdGlmZXNJaWNVY2dj?= =?utf-8?B?S2R4Rk4xZ1BRSmNoblprczY2bTlxWXFvSWlxQWt4U2lLWDVZT3M2Mkd2K3R5?= =?utf-8?B?dkI2dmYvalRPOFZFVHZZUGg2RnRyNXNDU09Pb2hteGJvRE5vajcvVXArbnh3?= =?utf-8?B?NGcxZ2JFRWE4VXRoNG9BWjdjekw5UFBvRTVscE5LNlRKcFRRNkEvT0d0Mjgy?= =?utf-8?B?YlR0QmJyNlZDcDBoVTdGS2tjV3NCbHl0dmlWWWY0bncyNXNWYkZMSnN1RVZt?= =?utf-8?B?WnJjZ1BuTVp3b3J5aisxMjZwMFZMNEc4UlJrQ3JTcW5ZTkpFTFFNbDk4Nmpy?= =?utf-8?B?Y2w2MmVlUEhwcmNZNFdTSkpqYzFrMEJCSXp2ckQxRzNhM2RwNDkwY3hCempu?= =?utf-8?B?dkFxZE45TVdxbW1NbzhPZUF2bjZlZ01GL3VESmtCeE9WZnNYWGtkS3paMlpM?= =?utf-8?B?ZjFXRVNMVnhTZy81bkhUby8zd2ZvR3NEMEw4MUVPUlphRGVFcDc0TE1QWEk4?= =?utf-8?B?NTAwNVpwWE8zV1diUVl5RmlFb1N5cjZ1WDA2cHoweDlpN3lnRnE5dmN2Z2sr?= =?utf-8?B?RVdyYW5EMWlzYVpFSlAwWmVpOFRIRVd1ZnRJUmw1b0Rwbklna252UitLb1pK?= =?utf-8?B?RDVTdmw3dkVKbEhrdVhnZEpTU2hUSUxEUFlZV2o4emRCUlVPM2ZNTGxRSUp4?= =?utf-8?B?ZVFWLzlqV0RuOGowMzF3VDZmNjBoeXE1bjR5dzBmV1ZGZDZzdXFENmtub2dx?= =?utf-8?B?T1FXWDVIZ0JlSlg3c21pc3FBaDhMMFg2K0h2THFuNDNMVHc1cHZFTnpWUnZZ?= =?utf-8?Q?fgAAgEOp8sZc4C4sNu6roxhNYRcwE5z7AD8ov2xq528E=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-d8e84.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 009416c0-dbb6-427c-6837-08db9ef9f2fb X-MS-Exchange-CrossTenant-AuthSource: SI2PR01MB5036.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2023 08:14:16.8331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR01MB5467 X-Spamd-Result: default: False [-2.45 / 15.00]; FORGED_MUA_SEAMONKEY_MSGID_UNKNOWN(2.50)[]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.952]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; R_SPF_ALLOW(-0.20)[+ip4:40.92.0.0/15]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[ports@freebsd.org]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; DKIM_TRACE(0.00)[hotmail.com:+]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; FROM_HAS_DN(0.00)[]; BLOCKLISTDE_FAIL(0.00)[40.92.53.58:server fail,2603:1096:4:1f8::9:server fail]; FREEMAIL_FROM(0.00)[hotmail.com]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.92.53.58:from] X-Spamd-Bar: -- X-Rspamd-Queue-Id: 4RRHpl0VPsz4Fnj Felix Palmen wrote on 2023/08/17 15:03: > * Tatsuki Makino [20230817 07:57]: >> Switching @comment by ${ARCH} is also in print/epson-inkjet-printer-escpr2. >> This is not a problem with check-orphans. > > It is, when some file doesn't exist for all architectures, but for more > than one of them. > > You first test the port on ARCH=foo. Then you test on ARCH=bar and find > that it builds/installs an additional tmp/something, so you prefix it > with %%BAR%% which expands to "@comment " unless building on ARCH=bar. > > Then you test on ARCH=baz which happens to build/install the same > tmp/something. plist-check will still be happy because the file is there > in pkg-plist (ignoring the @comment). Still, the file will be missing > from the package. > > I might try another workaround, e.g. expand to "@comment dummy/" > instead, so the name won't match and plist-check will complain ... epson-inkjet-printer-escpr2 is easy because it is restricted to 2 architectures, but in general it seems difficult. How about also making a combined PLIST_SUB in Makefile? .if ${ARCH} == foo PLIST_SUB+= FOO="" \ BAR="@comment " \ FOO_and_BAR="" .elif ${ARCH} == bar PLIST_SUB+= FOO="@comment " \ BAR="" \ FOO_and_BAR="" .else PLIST_SUB+= FOO_and_BAR="@comment " .endif And on pkg-plist side... %%FOO_and_BAR%%tmp/something There is one more thing that seems to be possible with pkg-plist. %%FOO%%%%BAR%%tmp/something If this means FOO && BAR, %%FOO%%tmp/something %%BAR%%tmp/something this would mean FOO || BAR. However, I do not know if it is allowed to write the same file name more than once, so it is time for an explanation by a great person :) According to Mk/Scripts/check-stagedir.sh, it only deletes lines with @comment at the beginning of the line, so there seems to be no problem... Regards.