Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Dec 2012 23:05:47 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Steven Hartland <smh@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r244188 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <20121214220547.GC1411@garage.freebsd.pl>
In-Reply-To: <201212131739.qBDHd8RR083616@svn.freebsd.org>
References:  <201212131739.qBDHd8RR083616@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--R+My9LyyhiUvIEro
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 13, 2012 at 05:39:08PM +0000, Steven Hartland wrote:
> Author: smh
> Date: Thu Dec 13 17:39:07 2012
> New Revision: 244188
> URL: http://svnweb.freebsd.org/changeset/base/244188
>=20
> Log:
>   Added vfs.zfs.vdev.trim_on_init sysctl which allows full vdev trim on
>   initialisation to be enabled (1) / disabled (0) defaults to enabled.
>  =20
>   This is useful for devices which have a slow trim speed and are either
>   new or have otherwise already been wiped e.g. secure erase.
>  =20
>   PR:     kern/173116
>   Submitted by:   Steven Hartland
>   Approved by:    pjd (mentor)
>=20
> Modified:
>   head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c
>=20
> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c	Thu =
Dec 13 17:06:38 2012	(r244187)
> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c	Thu =
Dec 13 17:39:07 2012	(r244188)
> @@ -148,6 +148,11 @@
>  #include <sys/trim_map.h>
>  #include <sys/fs/zfs.h>
> =20
> +static boolean_t vdev_trim_on_init =3D B_TRUE;
> +SYSCTL_DECL(_vfs_zfs_vdev);
> +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, trim_on_init, CTLFLAG_RW,
> +    &vdev_trim_on_init, 0, "Enable/disable full vdev trim on initialisat=
ion");

I'd also make it loader tunable.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--R+My9LyyhiUvIEro
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlDLorsACgkQForvXbEpPzSHdwCgvaY38hjAT2deQrwWQ3zpJr8P
9o8AoOBnBpVSuh7muBuwGO0TOvaD4exI
=aoAV
-----END PGP SIGNATURE-----

--R+My9LyyhiUvIEro--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121214220547.GC1411>