From owner-freebsd-virtualization@FreeBSD.ORG  Wed Sep 17 01:11:34 2008
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9D75106566C
	for <freebsd-virtualization@freebsd.org>;
	Wed, 17 Sep 2008 01:11:34 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outW.internet-mail-service.net (outw.internet-mail-service.net
	[216.240.47.246])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DD048FC12
	for <freebsd-virtualization@freebsd.org>;
	Wed, 17 Sep 2008 01:11:29 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id A3693242D;
	Tue, 16 Sep 2008 18:11:29 -0700 (PDT)
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id E7DA22D6013;
	Tue, 16 Sep 2008 18:11:28 -0700 (PDT)
Message-ID: <48D0593F.6050005@elischer.org>
Date: Tue, 16 Sep 2008 18:11:27 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
References: <200809081655.m88GtxbV000906@repoman.freebsd.org>
	<48C780E4.2050207@elischer.org>
	<20080916174040.Y65801@maildrop.int.zabbadoz.net>
In-Reply-To: <20080916174040.Y65801@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marko Zec <zec@FreeBSD.org>,
	FreeBSD virtualization mailing list <freebsd-virtualization@freebsd.org>
Subject: Re: Vnet iteration
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2008 01:11:34 -0000

Bjoern A. Zeeb wrote:
>> Marko Zec wrote:
> 
> Hi,
> 
>>> http://perforce.freebsd.org/chv.cgi?CH=149433
>>>
>>> Change 149433 by zec@zec_tpx32 on 2008/09/08 16:55:34
>>>
>>>     First-cut replacement of VNET_ITERLOOP_BEGIN() /
>>>     VNET_ITERLOOP_END() kludges with VNET_FOREACH() constructs
>>>     discussed at freebsd-virtualization@
>>>         Needs a bit more testing before merging over to
>>>     vimage-commit2 branch.
>>>
>>> Differences ...
>>
>> [...]
>>
>>> +    VNET_FOREACH(vnet_iter) {
>>> +        CURVNET_SET(vnet_iter);    /* XXX CURVNET_SET_QUIET() ? */
>>> +        INIT_VNET_NET(vnet_iter);
>>> +        TAILQ_FOREACH(ifp, &V_ifnet, if_link)
>>> +            (void)ifaddr_event_handler(NULL, ifp);
>>> +        CURVNET_RESTORE();
>>>      }
>>
>> this looks great..
>>
>> I'd like to see as much of this as possible in commit2
>> and then I'd like to see it committed as soon as brokk, bz and others 
>> have kicked the t[yi]res a bit.
>> :-)
> 
> 
> So can anyone bring it over to commit2? Marko, are you around?

I'm busy at work right now.

> 
> I had been generating a diff last weekend again to push this and found
> that the diff size changed from ~200k to ~800k so I suspect there was
> a mis-integration or someone forgot to set the label?

rerun the update script and select a change around the time of the
last integration and it should correct the label.

(on the other hand I think it's time for an update anyhow..)

> 
> 
> 
> /bz
>