From owner-freebsd-net@FreeBSD.ORG Mon Jan 14 22:17:14 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D7064AC7; Mon, 14 Jan 2013 22:17:14 +0000 (UTC) (envelope-from bright@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id C509AEF5; Mon, 14 Jan 2013 22:17:14 +0000 (UTC) Received: from Alfreds-MacBook-Pro-9.local (unknown [64.25.27.130]) by elvis.mu.org (Postfix) with ESMTPSA id B80AC1A3CD9; Mon, 14 Jan 2013 14:17:13 -0800 (PST) Message-ID: <50F483E8.2040107@mu.org> Date: Mon, 14 Jan 2013 17:17:12 -0500 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: John Baldwin Subject: Re: [PATCH] Don't imply TCP and UDP socket options are bitmasks References: <201301141550.13577.jhb@freebsd.org> <50F47BB8.9000409@mu.org> <201301141656.37175.jhb@freebsd.org> In-Reply-To: <201301141656.37175.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 22:17:14 -0000 On 1/14/13 4:56 PM, John Baldwin wrote: > On Monday, January 14, 2013 4:42:16 pm Alfred Perlstein wrote: >> Wouldn't a comment over the code suffice? >> >> Something like your email as a header would actually work very nicely! >> >> I think just using decimal would be more confusing than explicitly >> calling it out like: >> >> /* begin enumerated (not bitmask) socket option specifiers */ >> #define TCP_MAXSEG 0x02 /* set maximum segment size */ >> #define TCP_NOPUSH 0x04 /* don't push last block of write */ >> #define TCP_NOOPT 0x08 /* don't use TCP options */ >> #define TCP_MD5SIG 0x10 /* use MD5 digests (RFC2385) */ >> /* end enumerated socket option specifiers */ > I have a patch I'll post next which will add a new option as '3'. I think that > will make it more obvious and avoid having new options follow the old pattern. > Any objection to adding the contents of that email as a comment section? It really would help. -Alfred